* [PATCH] dmaengine: idxd: remove redudant idxd_wq_disable_cleanup() call
@ 2022-05-12 0:00 Dave Jiang
2022-05-16 12:49 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2022-05-12 0:00 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine
idxd_wq_device_reset_cleanup() already calls idxd_wq_disable_cleanup().
There is no need to call idxd_wq_disable_cleanup() again in
idxd_device_wqs_clear_state(). Remove redudant call from
idxd_wq_device_reset_cleanup().
Fixes: 0dcfe41e9a4c ("dmanegine: idxd: cleanup all device related bits after disabling device")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/dma/idxd/device.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 8d407d2bea4f..4617219376f7 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -395,7 +395,6 @@ static void idxd_wq_device_reset_cleanup(struct idxd_wq *wq)
{
lockdep_assert_held(&wq->wq_lock);
- idxd_wq_disable_cleanup(wq);
wq->size = 0;
wq->group = NULL;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: idxd: remove redudant idxd_wq_disable_cleanup() call
2022-05-12 0:00 [PATCH] dmaengine: idxd: remove redudant idxd_wq_disable_cleanup() call Dave Jiang
@ 2022-05-16 12:49 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-05-16 12:49 UTC (permalink / raw)
To: Dave Jiang; +Cc: dmaengine
On 11-05-22, 17:00, Dave Jiang wrote:
> idxd_wq_device_reset_cleanup() already calls idxd_wq_disable_cleanup().
> There is no need to call idxd_wq_disable_cleanup() again in
> idxd_device_wqs_clear_state(). Remove redudant call from
> idxd_wq_device_reset_cleanup().
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 0:00 [PATCH] dmaengine: idxd: remove redudant idxd_wq_disable_cleanup() call Dave Jiang
2022-05-16 12:49 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).