From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [4/7] dmaengine: sprd: Add device validation to support multiple controllers From: Vinod Koul Message-Id: <20190429140537.GN3845@vkoul-mobl.Dlink> Date: Mon, 29 Apr 2019 19:35:37 +0530 To: Baolin Wang Cc: Dan Williams , eric.long@unisoc.com, Orson Zhai , Chunyan Zhang , Mark Brown , dmaengine@vger.kernel.org, LKML List-ID: T24gMjktMDQtMTksIDIwOjIwLCBCYW9saW4gV2FuZyB3cm90ZToKPiBPbiBNb24sIDI5IEFwciAy MDE5IGF0IDE5OjU3LCBWaW5vZCBLb3VsIDx2a291bEBrZXJuZWwub3JnPiB3cm90ZToKPiA+Cj4g PiBPbiAxNS0wNC0xOSwgMjA6MTQsIEJhb2xpbiBXYW5nIHdyb3RlOgo+ID4gPiBGcm9tOiBFcmlj IExvbmcgPGVyaWMubG9uZ0B1bmlzb2MuY29tPgo+ID4gPgo+ID4gPiBTaW5jZSB3ZSBjYW4gc3Vw cG9ydCBtdWx0aXBsZSBETUEgZW5naW5lIGNvbnRyb2xsZXJzLCB3ZSBzaG91bGQgYWRkCj4gPiA+ IGRldmljZSB2YWxpZGF0aW9uIGluIGZpbHRlciBmdW5jdGlvbiB0byBjaGVjayBpZiB0aGUgY29y cmVjdCBjb250cm9sbGVyCj4gPiA+IHRvIGJlIHJlcXVlc3RlZC4KPiA+ID4KPiA+ID4gU2lnbmVk LW9mZi1ieTogRXJpYyBMb25nIDxlcmljLmxvbmdAdW5pc29jLmNvbT4KPiA+ID4gU2lnbmVkLW9m Zi1ieTogQmFvbGluIFdhbmcgPGJhb2xpbi53YW5nQGxpbmFyby5vcmc+Cj4gPiA+IC0tLQo+ID4g PiAgZHJpdmVycy9kbWEvc3ByZC1kbWEuYyB8ICAgIDUgKysrKysKPiA+ID4gIDEgZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKykKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1h L3NwcmQtZG1hLmMgYi9kcml2ZXJzL2RtYS9zcHJkLWRtYS5jCj4gPiA+IGluZGV4IDBmOTJlNjAu LjlmOTlkNGIgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZG1hL3NwcmQtZG1hLmMKPiA+ID4g KysrIGIvZHJpdmVycy9kbWEvc3ByZC1kbWEuYwo+ID4gPiBAQCAtMTAyMCw4ICsxMDIwLDEzIEBA IHN0YXRpYyB2b2lkIHNwcmRfZG1hX2ZyZWVfZGVzYyhzdHJ1Y3QgdmlydF9kbWFfZGVzYyAqdmQp Cj4gPiA+ICBzdGF0aWMgYm9vbCBzcHJkX2RtYV9maWx0ZXJfZm4oc3RydWN0IGRtYV9jaGFuICpj aGFuLCB2b2lkICpwYXJhbSkKPiA+ID4gIHsKPiA+ID4gICAgICAgc3RydWN0IHNwcmRfZG1hX2No biAqc2NoYW4gPSB0b19zcHJkX2RtYV9jaGFuKGNoYW4pOwo+ID4gPiArICAgICBzdHJ1Y3Qgb2Zf cGhhbmRsZV9hcmdzICpkbWFfc3BlYyA9Cj4gPiA+ICsgICAgICAgICAgICAgY29udGFpbmVyX29m KHBhcmFtLCBzdHJ1Y3Qgb2ZfcGhhbmRsZV9hcmdzLCBhcmdzWzBdKTsKPiA+ID4gICAgICAgdTMy IHNsYXZlX2lkID0gKih1MzIgKilwYXJhbTsKPiA+ID4KPiA+ID4gKyAgICAgaWYgKGNoYW4tPmRl dmljZS0+ZGV2LT5vZl9ub2RlICE9IGRtYV9zcGVjLT5ucCkKPiA+Cj4gPiBBcmUgeW91IG5vdCB1 c2luZyBvZl9kbWFfZmluZF9jb250cm9sbGVyKCkgdGhhdCBkb2VzIHRoaXMsIHNvIHRoaXMgd291 bGQKPiA+IGJlIHVzZWxlc3MhCj4gCj4gWWVzLCB3ZSBjYW4gdXNlIG9mX2RtYV9maW5kX2NvbnRy b2xsZXIoKSwgYnV0IHRoYXQgd2lsbCBiZSBhIGxpdHRsZQo+IGNvbXBsaWNhdGVkIHRoYW4gY3Vy cmVudCBzb2x1dGlvbi4gU2luY2Ugd2UgbmVlZCBpbnRyb2R1Y2Ugb25lCj4gc3RydWN0dXJlIHRv IHNhdmUgdGhlIG5vZGUgdG8gdmFsaWRhdGUgaW4gdGhlIGZpbHRlciBmdW5jdGlvbiBsaWtlCj4g YmVsb3csIHdoaWNoIHNlZW1zIG1ha2UgdGhpbmdzIGNvbXBsaWNhdGVkLiBCdXQgaWYgeW91IHN0 aWxsIGxpa2UgdG8KPiB1c2Ugb2ZfZG1hX2ZpbmRfY29udHJvbGxlcigpLCBJIGNhbiBjaGFuZ2Ug dG8gdXNlIGl0IGluIG5leHQgdmVyc2lvbi4KClNvcnJ5IEkgc2hvdWxkIGhhdmUgY2xhcmlmaWVk IG1vcmUuLgoKb2ZfZG1hX2ZpbmRfY29udHJvbGxlcigpIGlzIGNhbGxlZCBieSB4bGF0ZSwgc28g eW91IGFscmVhZHkgcnVuIHRoaXMKY2hlY2ssIHNvIHdoeSB1c2UgdGhpcyA6KQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F5C0C43219 for ; Mon, 29 Apr 2019 14:05:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E116C21707 for ; Mon, 29 Apr 2019 14:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556546746; bh=qVipqbpF74NslrIJAp2+g2vf/JWQWFLexrajOnRDUME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JmOhDt7m9nRWhWPNcZhsr7w2YDrzIpWKYB7bvK0Dx2oMHw8AHoJJN4X62js8h8Aem suoOp/uoij/2SbVqlCmqQjLkwPQMoMkLvxJUVUrq27nJSvvB9qNhctnctbBE9ySZXb XwN46lF58o8o2gUQ1pp2UK5SZpjAgRufQAjxEgy8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728252AbfD2OFp (ORCPT ); Mon, 29 Apr 2019 10:05:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:55532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728239AbfD2OFp (ORCPT ); Mon, 29 Apr 2019 10:05:45 -0400 Received: from localhost (unknown [171.76.113.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F7F421655; Mon, 29 Apr 2019 14:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556546744; bh=qVipqbpF74NslrIJAp2+g2vf/JWQWFLexrajOnRDUME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p3+1k8xq616yFT7vtr8zz46qwCOa5a6V/y261xa0fS2qnBYuLYJyKsbAYmM7hLitL fjn8DDIuZaH2gGmzjcNxTjXKiK/x1c4nBCPY41rJshPGlL3B1JbdGz1J2YH18KI2J1 vZrKmC68zix+9Akq8rvNGJvMTflpDK+LzAw7mcRU= Date: Mon, 29 Apr 2019 19:35:37 +0530 From: Vinod Koul To: Baolin Wang Cc: Dan Williams , eric.long@unisoc.com, Orson Zhai , Chunyan Zhang , Mark Brown , dmaengine@vger.kernel.org, LKML Subject: Re: [PATCH 4/7] dmaengine: sprd: Add device validation to support multiple controllers Message-ID: <20190429140537.GN3845@vkoul-mobl.Dlink> References: <20190429115723.GK3845@vkoul-mobl.Dlink> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190429140537.1eh2zHA-EdCnItmmhfCh-G5_cqheud693gWlQZHsCIo@z> On 29-04-19, 20:20, Baolin Wang wrote: > On Mon, 29 Apr 2019 at 19:57, Vinod Koul wrote: > > > > On 15-04-19, 20:14, Baolin Wang wrote: > > > From: Eric Long > > > > > > Since we can support multiple DMA engine controllers, we should add > > > device validation in filter function to check if the correct controller > > > to be requested. > > > > > > Signed-off-by: Eric Long > > > Signed-off-by: Baolin Wang > > > --- > > > drivers/dma/sprd-dma.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c > > > index 0f92e60..9f99d4b 100644 > > > --- a/drivers/dma/sprd-dma.c > > > +++ b/drivers/dma/sprd-dma.c > > > @@ -1020,8 +1020,13 @@ static void sprd_dma_free_desc(struct virt_dma_desc *vd) > > > static bool sprd_dma_filter_fn(struct dma_chan *chan, void *param) > > > { > > > struct sprd_dma_chn *schan = to_sprd_dma_chan(chan); > > > + struct of_phandle_args *dma_spec = > > > + container_of(param, struct of_phandle_args, args[0]); > > > u32 slave_id = *(u32 *)param; > > > > > > + if (chan->device->dev->of_node != dma_spec->np) > > > > Are you not using of_dma_find_controller() that does this, so this would > > be useless! > > Yes, we can use of_dma_find_controller(), but that will be a little > complicated than current solution. Since we need introduce one > structure to save the node to validate in the filter function like > below, which seems make things complicated. But if you still like to > use of_dma_find_controller(), I can change to use it in next version. Sorry I should have clarified more.. of_dma_find_controller() is called by xlate, so you already run this check, so why use this :) -- ~Vinod