From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC] dmaengine: add fifo_size member From: Vinod Koul Message-Id: <20190502060446.GI3845@vkoul-mobl.Dlink> Date: Thu, 2 May 2019 11:34:46 +0530 To: Sameer Pujar Cc: dan.j.williams@intel.com, tiwai@suse.com, jonathanh@nvidia.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gMzAtMDQtMTksIDE3OjAwLCBTYW1lZXIgUHVqYXIgd3JvdGU6Cj4gRHVyaW5nIHRoZSBETUEg dHJhbnNmZXJzIGZyb20gbWVtb3J5IHRvIEkvTywgaXQgd2FzIG9ic2VydmVkIHRoYXQgdHJhbnNm ZXJzCj4gd2VyZSBpbmNvbnNpc3RlbnQgYW5kIHJlc3VsdGVkIGluIGdsaXRjaGVzIGZvciBhdWRp byBwbGF5YmFjay4gSXQgaGFwcGVuZWQKPiBiZWNhdXNlIGZpZm8gc2l6ZSBvbiBETUEgZGlkIG5v dCBtYXRjaCB3aXRoIHNsYXZlIGNoYW5uZWwgY29uZmlndXJhdGlvbi4KPiAKPiBjdXJyZW50bHkg J2RtYV9zbGF2ZV9jb25maWcnIHN0cnVjdHVyZSBkb2VzIG5vdCBoYXZlIGEgZmllbGQgZm9yIGZp Zm8gc2l6ZS4KPiBIZW5jZSB0aGUgcGxhdGZvcm0gcGNtIGRyaXZlciBjYW5ub3QgcGFzcyB0aGUg ZmlmbyBzaXplIGFzIGEgc2xhdmVfY29uZmlnLgo+IE5vdGUgdGhhdCAnc25kX2RtYWVuZ2luZV9k YWlfZG1hX2RhdGEnIHN0cnVjdHVyZSBoYXMgZmlmb19zaXplIGZpZWxkIHdoaWNoCj4gY2Fubm90 IGJlIHVzZWQgdG8gcGFzcyB0aGUgc2l6ZSBpbmZvLiBUaGlzIHBhdGNoIGludHJvZHVjZXMgZmlm b19zaXplIGZpZWxkCj4gYW5kIHRoZSBzYW1lIGNhbiBiZSBwb3B1bGF0ZWQgb24gc2xhdmUgc2lk ZS4gVXNlcnMgY2FuIHNldCByZXF1aXJlZCBzaXplCj4gZm9yIHNsYXZlIHBlcmlwaGVyYWwgKG11 bHRpcGxlIGNoYW5uZWxzIGNhbiBiZSBpbmRlcGVuZGVudGx5IHJ1bm5pbmcgd2l0aAo+IGRpZmZl cmVudCBmaWZvIHNpemVzKSBhbmQgdGhlIGNvcnJlc3BvbmRpbmcgc2l6ZXMgYXJlIHByb2dyYW1t ZWQgdGhyb3VnaAo+IGRtYV9zbGF2ZV9jb25maWcgb24gRE1BIHNpZGUuCgpGSUZPIHNpemUgaXMg YSBoYXJkd2FyZSBwcm9wZXJ0eSBub3Qgc3VyZSB3aHkgeW91IHdvdWxkIHdhbnQgYW4KaW50ZXJm YWNlIHRvIHByb2dyYW0gdGhhdD8KCk9uIG1pc21hdGNoLCBJIGd1ZXNzIHlvdSBuZWVkIHRvIHRh a2UgY2FyZSBvZiBzcmMvZHN0X21heGJ1cnN0Li4KCj4gCj4gUmVxdWVzdCBmb3IgZmVlZGJhY2sv c3VnZ2VzdGlvbnMuCj4gCj4gU2lnbmVkLW9mZi1ieTogU2FtZWVyIFB1amFyIDxzcHVqYXJAbnZp ZGlhLmNvbT4KPiAtLS0KPiAgaW5jbHVkZS9saW51eC9kbWFlbmdpbmUuaCB8IDMgKysrCj4gIDEg ZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9s aW51eC9kbWFlbmdpbmUuaCBiL2luY2x1ZGUvbGludXgvZG1hZW5naW5lLmgKPiBpbmRleCBkNDll YzVjLi45ZWMxOThiIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvZG1hZW5naW5lLmgKPiAr KysgYi9pbmNsdWRlL2xpbnV4L2RtYWVuZ2luZS5oCj4gQEAgLTM1MSw2ICszNTEsOCBAQCBlbnVt IGRtYV9zbGF2ZV9idXN3aWR0aCB7Cj4gICAqIEBzbGF2ZV9pZDogU2xhdmUgcmVxdWVzdGVyIGlk LiBPbmx5IHZhbGlkIGZvciBzbGF2ZSBjaGFubmVscy4gVGhlIGRtYQo+ICAgKiBzbGF2ZSBwZXJp cGhlcmFsIHdpbGwgaGF2ZSB1bmlxdWUgaWQgYXMgZG1hIHJlcXVlc3RlciB3aGljaCBuZWVkIHRv IGJlCj4gICAqIHBhc3MgYXMgc2xhdmUgY29uZmlnLgo+ICsgKiBAZmlmb19zaXplOiBGaWZvIHNp emUgdmFsdWUuIFRoZSBkbWEgc2xhdmUgcGVyaXBoZXJhbCBjYW4gY29uZmlndXJlIHJlcXVpcmVk Cj4gKyAqIGZpZm8gc2l6ZSBhbmQgdGhlIHNhbWUgbmVlZHMgdG8gYmUgcGFzc2VkIGFzIHNsYXZl IGNvbmZpZy4KPiAgICoKPiAgICogVGhpcyBzdHJ1Y3QgaXMgcGFzc2VkIGluIGFzIGNvbmZpZ3Vy YXRpb24gZGF0YSB0byBhIERNQSBlbmdpbmUKPiAgICogaW4gb3JkZXIgdG8gc2V0IHVwIGEgY2Vy dGFpbiBjaGFubmVsIGZvciBETUEgdHJhbnNwb3J0IGF0IHJ1bnRpbWUuCj4gQEAgLTM3Niw2ICsz NzgsNyBAQCBzdHJ1Y3QgZG1hX3NsYXZlX2NvbmZpZyB7Cj4gIAl1MzIgZHN0X3BvcnRfd2luZG93 X3NpemU7Cj4gIAlib29sIGRldmljZV9mYzsKPiAgCXVuc2lnbmVkIGludCBzbGF2ZV9pZDsKPiAr CXUzMiBmaWZvX3NpemU7Cj4gIH07Cj4gIAo+ICAvKioKPiAtLSAKPiAyLjcuNAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D65C43219 for ; Thu, 2 May 2019 06:04:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74FAA2089E for ; Thu, 2 May 2019 06:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556777097; bh=AIbpzp/IDy0CStv4gzV133Vm7XU8kRQPpGQnibvVotw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gVn/Ms14YdLsD4jyuVnqK1JLsw3mfOvhqL+TnjkNdEozEAREw6EkGv9QCpMEfI7rr okX+rfnAyk0EYPO/d3Gt7khePCqVAgwkxEURYs3SILDjjhRpuam7QMWe6E5RjMZXpZ Zaa33CJtTJbyyxS9TMq0+odN5VPl5eRhypZXZGCA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726224AbfEBGE5 (ORCPT ); Thu, 2 May 2019 02:04:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:46710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfEBGE4 (ORCPT ); Thu, 2 May 2019 02:04:56 -0400 Received: from localhost (unknown [171.76.113.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 271722081C; Thu, 2 May 2019 06:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556777096; bh=AIbpzp/IDy0CStv4gzV133Vm7XU8kRQPpGQnibvVotw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fKBQrLQySLJTXow2/VlS55JsED+AA0f7bOfytCZHFjpB+81Mrp4W4PZmQ5VzKz3iv 5lUhRZuxmmkQLE5ZmC1Jz0SofYDFJXS1CNrFtJ0TI42F3IWztOWnBn9f2RTzEWsfNS JVKk8WAxc3/+TYCgRAseNK1G9HYnaO9nFse2+Mzw= Date: Thu, 2 May 2019 11:34:46 +0530 From: Vinod Koul To: Sameer Pujar Cc: dan.j.williams@intel.com, tiwai@suse.com, jonathanh@nvidia.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] dmaengine: add fifo_size member Message-ID: <20190502060446.GI3845@vkoul-mobl.Dlink> References: <1556623828-21577-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1556623828-21577-1-git-send-email-spujar@nvidia.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190502060446.QGmq3q6hd3uPrWTQkcSiaIHnTE4nV5tcHv8U3ek77KY@z> On 30-04-19, 17:00, Sameer Pujar wrote: > During the DMA transfers from memory to I/O, it was observed that transfers > were inconsistent and resulted in glitches for audio playback. It happened > because fifo size on DMA did not match with slave channel configuration. > > currently 'dma_slave_config' structure does not have a field for fifo size. > Hence the platform pcm driver cannot pass the fifo size as a slave_config. > Note that 'snd_dmaengine_dai_dma_data' structure has fifo_size field which > cannot be used to pass the size info. This patch introduces fifo_size field > and the same can be populated on slave side. Users can set required size > for slave peripheral (multiple channels can be independently running with > different fifo sizes) and the corresponding sizes are programmed through > dma_slave_config on DMA side. FIFO size is a hardware property not sure why you would want an interface to program that? On mismatch, I guess you need to take care of src/dst_maxburst.. > > Request for feedback/suggestions. > > Signed-off-by: Sameer Pujar > --- > include/linux/dmaengine.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index d49ec5c..9ec198b 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -351,6 +351,8 @@ enum dma_slave_buswidth { > * @slave_id: Slave requester id. Only valid for slave channels. The dma > * slave peripheral will have unique id as dma requester which need to be > * pass as slave config. > + * @fifo_size: Fifo size value. The dma slave peripheral can configure required > + * fifo size and the same needs to be passed as slave config. > * > * This struct is passed in as configuration data to a DMA engine > * in order to set up a certain channel for DMA transport at runtime. > @@ -376,6 +378,7 @@ struct dma_slave_config { > u32 dst_port_window_size; > bool device_fc; > unsigned int slave_id; > + u32 fifo_size; > }; > > /** > -- > 2.7.4 -- ~Vinod