From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CD54C04AA9 for ; Thu, 2 May 2019 07:00:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA9032085A for ; Thu, 2 May 2019 06:59:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725795AbfEBG77 (ORCPT ); Thu, 2 May 2019 02:59:59 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:47647 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726186AbfEBG74 (ORCPT ); Thu, 2 May 2019 02:59:56 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hM5gz-0008TR-Au; Thu, 02 May 2019 08:59:41 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hM5gx-0007lH-EQ; Thu, 02 May 2019 08:59:39 +0200 Date: Thu, 2 May 2019 08:59:39 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Robin Gong , "robh+dt@kernel.org" Cc: "broonie@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "mark.rutland@arm.com" , "plyatov@gmail.com" , "dan.j.williams@intel.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [PATCH v2 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed Message-ID: <20190502065939.nyejomrsowhy6xox@pengutronix.de> References: <1556265512-9130-1-git-send-email-yibin.gong@nxp.com> <1556265512-9130-9-git-send-email-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1556265512-9130-9-git-send-email-yibin.gong@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190502065939.t9uhhfRGLyb4-eBrTikskT5dGO4HfTnwKsNrE8T-jOY@z> On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote: > ERR009165 fixed from i.mx6ul, add it to show the errata fixed. > > Signed-off-by: Robin Gong > --- > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > index 2d32641..32c4263d 100644 > --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > @@ -10,6 +10,8 @@ Required properties: > - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 > - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 > - "fsl,imx53-ecspi" for SPI compatible with the one integrated on i.MX53 and later Soc > + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc > + (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf) I wouldn't mention this errata in the binding documentation. Just state that fsl,imx6ul-ecspi is designed to be used on i.MX6UL. And that it might also be used on later SoCs as a "fallback compatible" is a detail that is so common that I would expect it not being worth mentioning. So for me it would also be OK to drop "fsl,imx53-ecspi" from the list as this is only used like: compatible = "fsl,imx53-ecspi", "fsl,imx51-ecspi"; (But note that I have no authority here.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |