From: Vinod Koul <vkoul@kernel.org>
To: Kazuhiro Kasai <kasai.kazuhiro@socionext.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
orito.takao@socionext.com, sugaya.taichi@socionext.com,
kanematsu.shinji@socionext.com, jaswinder.singh@linaro.org,
masami.hiramatsu@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dmaengine: milbeaut: Add Milbeaut AXI DMA controller
Date: Tue, 7 May 2019 22:40:43 +0530 [thread overview]
Message-ID: <20190507171042.GS16052@vkoul-mobl> (raw)
In-Reply-To: <20190507053924.GA3359@ubuntu>
On 07-05-19, 14:39, Kazuhiro Kasai wrote:
> On Fri, Apr 26, 2019 at 17:16 +0530, Vinod Koul wrote:
> > On 25-03-19, 13:15, Kazuhiro Kasai wrote:
> > > +struct m10v_dma_chan {
> > > + struct dma_chan chan;
> > > + struct m10v_dma_device *mdmac;
> > > + void __iomem *regs;
> > > + int irq;
> > > + struct m10v_dma_desc mdesc;
> >
> > So there is a *single* descriptor? Not a list??
>
> Yes, single descriptor.
And why is that, you can create a list and keep getting descriptors and
issue them to hardware and get better pref!
> > > +static dma_cookie_t m10v_xdmac_tx_submit(struct dma_async_tx_descriptor *txd)
> > > +{
> > > + struct m10v_dma_chan *mchan = to_m10v_dma_chan(txd->chan);
> > > + dma_cookie_t cookie;
> > > + unsigned long flags;
> > > +
> > > + spin_lock_irqsave(&mchan->lock, flags);
> > > + cookie = dma_cookie_assign(txd);
> > > + spin_unlock_irqrestore(&mchan->lock, flags);
> > > +
> > > + return cookie;
> >
> > sounds like vchan_tx_submit() i think you can use virt-dma layer and then
> > get rid of artificial limit in driver and be able to queue up the txn on
> > dmaengine.
>
> OK, I will try to use virt-dma layer in next version.
And you will get lists to manage descriptor for free! so you can use
that to support multiple txns as well!
> > > +static struct dma_async_tx_descriptor *
> > > +m10v_xdmac_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
> > > + dma_addr_t src, size_t len, unsigned long flags)
> > > +{
> > > + struct m10v_dma_chan *mchan = to_m10v_dma_chan(chan);
> > > +
> > > + dma_async_tx_descriptor_init(&mchan->mdesc.txd, chan);
> > > + mchan->mdesc.txd.tx_submit = m10v_xdmac_tx_submit;
> > > + mchan->mdesc.txd.callback = NULL;
> > > + mchan->mdesc.txd.flags = flags;
> > > + mchan->mdesc.txd.cookie = -EBUSY;
> > > +
> > > + mchan->mdesc.len = len;
> > > + mchan->mdesc.src = src;
> > > + mchan->mdesc.dst = dst;
> > > +
> > > + return &mchan->mdesc.txd;
> >
> > So you support single descriptor and dont check if this has been already
> > configured. So I guess this has been tested by doing txn one at a time
> > and not submitted bunch of txn and wait for them to complete. Please fix
> > that to really enable dmaengine capabilities.
>
> Thank you for advice. I want to fix it and I have 2 questions.
>
> 1. Does virt-dma layer help to fix this?
Yes
> 2. Can dmatest test that dmaengine capabilities?
Yes for memcpy operations, see Documentation/driver-api/dmaengine/dmatest.rst
--
~Vinod
next prev parent reply other threads:[~2019-05-07 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1553487314-9185-1-git-send-email-kasai.kazuhiro@socionext.com>
2019-03-25 4:15 ` [2/2] dmaengine: milbeaut: Add Milbeaut AXI DMA controller Kazuhiro Kasai
2019-04-16 2:06 ` Kazuhiro Kasai
2019-04-16 2:06 ` [PATCH 2/2] " Kazuhiro Kasai
2019-04-26 11:46 ` [2/2] " Vinod Koul
2019-04-26 11:46 ` [PATCH 2/2] " Vinod Koul
2019-05-07 5:39 ` Kazuhiro Kasai
2019-05-07 17:10 ` Vinod Koul [this message]
2019-05-07 23:37 ` Kazuhiro Kasai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507171042.GS16052@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jaswinder.singh@linaro.org \
--cc=kanematsu.shinji@socionext.com \
--cc=kasai.kazuhiro@socionext.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masami.hiramatsu@linaro.org \
--cc=orito.takao@socionext.com \
--cc=robh+dt@kernel.org \
--cc=sugaya.taichi@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).