From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 425B7C04AAF for ; Tue, 21 May 2019 06:12:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14C9521773 for ; Tue, 21 May 2019 06:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558419162; bh=4VC9bKP9QU7iVDFMtdo9WoMzmY1tJYqXCWxT9T/NUpY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ODjAnwNVo4xiAkQPChYycTitqYsDTfx53d2Kzn2g3+CXBCE1I7T7ZucVkhNtGLmNh 7wZUnEtYoqGK3NLo2kft98xtb3Br9c7+RwMGUkQ2/5CpymB+087oNINrvXrpSttfxi 1sIwVNFLnb5DWq+KfdPR6oLwYFDXAXf2Utjrw/yQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725835AbfEUGMl (ORCPT ); Tue, 21 May 2019 02:12:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:49188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbfEUGMl (ORCPT ); Tue, 21 May 2019 02:12:41 -0400 Received: from localhost (unknown [106.201.107.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDFC920863; Tue, 21 May 2019 06:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558419160; bh=4VC9bKP9QU7iVDFMtdo9WoMzmY1tJYqXCWxT9T/NUpY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lJzLTxcVnQlcC8g5MlkXWsEtukxQJremgG+7zcGYuVRwfHSSl/CjVbwp62oapFxjZ RB3v+k7IXX6G0ix1zRMQJ2OvmqFFR1LCVcZnUWQFvAHionw5nVJu6KU8/EW2X/ujcW XyM9/dqc3r3hrt7uRZc5BRuGjG8gjJF0yevCkmSg= Date: Tue, 21 May 2019 11:42:36 +0530 From: Vinod Koul To: Robin Gong Cc: "robh@kernel.org" , "broonie@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "mark.rutland@arm.com" , "u.kleine-koenig@pengutronix.de" , "plyatov@gmail.com" , "dan.j.williams@intel.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "l.stach@pengutronix.de" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: Re: Re: [PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Message-ID: <20190521061236.GA15118@vkoul-mobl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 21-05-19, 05:41, Robin Gong wrote: > > -----Original Message----- > > From: Vinod Koul > > Sent: 2019年5月21日 13:13 > > > > On 21-05-19, 04:58, Robin Gong wrote: > > > > -----Original Message----- > > > > From: Vinod Koul > > > > Sent: 2019年5月21日 12:18 > > > > > > > > On 07-05-19, 09:16, Robin Gong wrote: > > > > > Because the number of ecspi1 rx event on i.mx8mm is 0, the > > > > > condition check ignore such special case without dma channel > > > > > enabled, which caused > > > > > ecspi1 rx works failed. Actually, no need to check event_id0, > > > > > checking > > > > > event_id1 is enough for DEV_2_DEV case because it's so lucky that > > > > > event_id1 never be 0. > > > > > > > > Well is that by chance or design that event_id1 will be never 0? > > > > > > > That's by chance. DEV_2_DEV is just for Audio case and non-zero for > > event_id1 on current i.MX family. > > > > Then it wont be fgood to rely on chance :) > Yes, I knew that. May I create another independent patch for event_id1 since that's potential issue is not related with this ecspi patch set? Sure a patch should change one thing but I think it should come before this one. The log for this should be fixed up as well -- ~Vinod