From: Vinod Koul <vkoul@kernel.org>
To: Peng Ma <peng.ma@nxp.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [V3 2/2] dmaengine: fsl-qdma: Add improvement
Date: Tue, 4 Jun 2019 17:37:33 +0530 [thread overview]
Message-ID: <20190604120733.GV15118@vkoul-mobl> (raw)
In-Reply-To: <20190522032103.13713-2-peng.ma@nxp.com>
On 22-05-19, 03:21, Peng Ma wrote:
> When an error occurs we should clean the error register then to return
The patch title is supposed to tell us about the change. "Add
improvement: is a very generic term!
I have change title to "Continue to clear register on error" and applied
>
> Signed-off-by: Peng Ma <peng.ma@nxp.com>
> ---
> changed for V3:
> - no changed.
>
> drivers/dma/fsl-qdma.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
> index da8fdf5..8e341c0 100644
> --- a/drivers/dma/fsl-qdma.c
> +++ b/drivers/dma/fsl-qdma.c
> @@ -703,10 +703,8 @@ static irqreturn_t fsl_qdma_error_handler(int irq, void *dev_id)
>
> intr = qdma_readl(fsl_qdma, status + FSL_QDMA_DEDR);
>
> - if (intr) {
> + if (intr)
> dev_err(fsl_qdma->dma_dev.dev, "DMA transaction error!\n");
> - return IRQ_NONE;
> - }
>
> qdma_writel(fsl_qdma, FSL_QDMA_DEDR_CLEAR, status + FSL_QDMA_DEDR);
> return IRQ_HANDLED;
> --
> 1.7.1
--
~Vinod
next prev parent reply other threads:[~2019-06-04 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 3:21 [V3 1/2] dmaengine: fsl-qdma: fixed the source/destination descriptor format Peng Ma
2019-05-22 3:21 ` [V3 2/2] dmaengine: fsl-qdma: Add improvement Peng Ma
2019-06-04 12:07 ` Vinod Koul [this message]
2019-06-04 12:06 ` [V3 1/2] dmaengine: fsl-qdma: fixed the source/destination descriptor format Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604120733.GV15118@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.ma@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).