From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Dan Williams <dan.j.williams@intel.com>, Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH/RFC] dmaengine: Create symlinks from DMA channels to slaves
Date: Fri, 7 Jun 2019 13:38:35 +0200 [thread overview]
Message-ID: <20190607113835.15376-1-geert+renesas@glider.be> (raw)
Currently it is not easy to find out which DMA channels are in use, and
by which slave devices.
Fix this by creating in sysfs a "slave" symlink from the DMA channel to
the actual slave device when a channel is requested, and removing it
again when the channel is released.
For now this is limited to DT and ACPI.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Questions:
1. Do you think this is useful?
2. Should backlinks (e.g. "dma:<name>") be created from the slave
device to the DMA channel?
This requires storing the name in struct dma_chan, for later
symlink removal.
3. Should this be extended to other ways of requesting channels?
In many cases, no device pointer is available, so a device pointer
parameter has to be added to all DMA channel request APIs that
don't have it yet.
---
drivers/dma/dmaengine.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index 03ac4b96117cd8db..c11476f76fc96bcf 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -706,6 +706,10 @@ struct dma_chan *dma_request_chan(struct device *dev, const char *name)
if (chan) {
/* Valid channel found or requester needs to be deferred */
+ if (!IS_ERR(chan) &&
+ sysfs_create_link(&chan->dev->device.kobj, &dev->kobj,
+ "slave"))
+ dev_err(dev, "Cannot create DMA slave symlink\n");
if (!IS_ERR(chan) || PTR_ERR(chan) == -EPROBE_DEFER)
return chan;
}
@@ -786,6 +790,7 @@ void dma_release_channel(struct dma_chan *chan)
/* drop PRIVATE cap enabled by __dma_request_channel() */
if (--chan->device->privatecnt == 0)
dma_cap_clear(DMA_PRIVATE, chan->device->cap_mask);
+ sysfs_remove_link(&chan->dev->device.kobj, "slave");
mutex_unlock(&dma_list_mutex);
}
EXPORT_SYMBOL_GPL(dma_release_channel);
--
2.17.1
next reply other threads:[~2019-06-07 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 11:38 Geert Uytterhoeven [this message]
2019-06-10 7:54 ` [PATCH/RFC] dmaengine: Create symlinks from DMA channels to slaves Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607113835.15376-1-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).