[PATCH v1] dmaengine: hsu: Revert "set HSU_CH_MTSR to memory width"

[PATCH v1] dmaengine: hsu: Revert "set HSU_CH_MTSR to memory width"

[Andy Shevchenko]

The commit

  080edf75d337 ("dmaengine: hsu: set HSU_CH_MTSR to memory width")

has been mistakenly submitted. The further investigations show that
the original code does better job since the memory side transfer size
has never been configured by DMA users.

As per latest revision of documentation: "Channel minimum transfer size
(CHnMTSR)... For IOSF UART, maximum value that can be programmed is 64 and
minimum value that can be programmed is 1."

This reverts commit 080edf75d337d35faa6fc3df99342b10d2848d16.

Fixes: 080edf75d337 ("dmaengine: hsu: set HSU_CH_MTSR to memory width")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/dma/hsu/hsu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/hsu/hsu.c b/drivers/dma/hsu/hsu.c
index e06f20272fd7..dfabc64c2ab0 100644
--- a/drivers/dma/hsu/hsu.c
+++ b/drivers/dma/hsu/hsu.c
@@ -64,10 +64,10 @@ static void hsu_dma_chan_start(struct hsu_dma_chan *hsuc)
 
 	if (hsuc->direction == DMA_MEM_TO_DEV) {
 		bsr = config->dst_maxburst;
-		mtsr = config->src_addr_width;
+		mtsr = config->dst_addr_width;
 	} else if (hsuc->direction == DMA_DEV_TO_MEM) {
 		bsr = config->src_maxburst;
-		mtsr = config->dst_addr_width;
+		mtsr = config->src_addr_width;
 	}
 
 	hsu_chan_disable(hsuc);
-- 
2.20.1

Re: [PATCH v1] dmaengine: hsu: Revert "set HSU_CH_MTSR to memory width"

[Vinod Koul]

On 13-06-19, 16:32, Andy Shevchenko wrote:
> The commit
> 
>   080edf75d337 ("dmaengine: hsu: set HSU_CH_MTSR to memory width")
> 
> has been mistakenly submitted. The further investigations show that
> the original code does better job since the memory side transfer size
> has never been configured by DMA users.
> 
> As per latest revision of documentation: "Channel minimum transfer size
> (CHnMTSR)... For IOSF UART, maximum value that can be programmed is 64 and
> minimum value that can be programmed is 1."

Applied, thanks

-- 
~Vinod