From: Fabio Estevam <festevam@gmail.com>
To: vkoul@kernel.org
Cc: krzk@kernel.org, cphealy@gmail.com, peng.ma@nxp.com,
dmaengine@vger.kernel.org, Fabio Estevam <festevam@gmail.com>
Subject: [PATCH v2] Revert "dmaengine: fsl-edma: support little endian for edma driver"
Date: Tue, 2 Jul 2019 13:48:52 -0300 [thread overview]
Message-ID: <20190702164852.3195-1-festevam@gmail.com> (raw)
This reverts commit 002905eca5bedab08bafd9e325bbbb41670c7712.
Commit 002905eca5be ("dmaengine: fsl-edma: support little endian for edma
driver") incorrectly assumed that there was not little endian support
in the driver.
This causes hangs on Vybrid, so revert it so that Vybrid systems
could boot again.
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v1:
- Updated Krzysztof's e-mail address
- Collected Krzysztof's Tested-by
drivers/dma/fsl-edma-common.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
index 6bf238e19d91..680b2a00a953 100644
--- a/drivers/dma/fsl-edma-common.c
+++ b/drivers/dma/fsl-edma-common.c
@@ -83,14 +83,9 @@ void fsl_edma_chan_mux(struct fsl_edma_chan *fsl_chan,
u32 ch = fsl_chan->vchan.chan.chan_id;
void __iomem *muxaddr;
unsigned int chans_per_mux, ch_off;
- int endian_diff[4] = {3, 1, -1, -3};
chans_per_mux = fsl_chan->edma->n_chans / DMAMUX_NR;
ch_off = fsl_chan->vchan.chan.chan_id % chans_per_mux;
-
- if (!fsl_chan->edma->big_endian)
- ch_off += endian_diff[ch_off % 4];
-
muxaddr = fsl_chan->edma->muxbase[ch / chans_per_mux];
slot = EDMAMUX_CHCFG_SOURCE(slot);
--
2.17.1
next reply other threads:[~2019-07-02 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 16:48 Fabio Estevam [this message]
2019-07-03 7:55 ` [PATCH v2] Revert "dmaengine: fsl-edma: support little endian for edma driver" Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702164852.3195-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=cphealy@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=peng.ma@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).