dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] dmaengine: bcm2835: Print error in case setting DMA mask fails
@ 2019-07-16 17:15 Stefan Wahren
  2019-07-22 14:26 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Wahren @ 2019-07-16 17:15 UTC (permalink / raw)
  To: Dan Williams, Vinod Koul, Eric Anholt, Florian Fainelli, Ray Jui,
	Scott Branden
  Cc: bcm-kernel-feedback-list, dmaengine, linux-arm-kernel,
	linux-rpi-kernel, linux-kernel, Stefan Wahren

During enabling of the RPi 4, we found out that the driver doesn't provide
a helpful error message in case setting DMA mask fails. So add one.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
 drivers/dma/bcm2835-dma.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 8101ff2f..970f654 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -871,8 +871,10 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
 		pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;

 	rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
-	if (rc)
+	if (rc) {
+		dev_err(&pdev->dev, "Unable to set DMA mask\n");
 		return rc;
+	}

 	od = devm_kzalloc(&pdev->dev, sizeof(*od), GFP_KERNEL);
 	if (!od)
--
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dmaengine: bcm2835: Print error in case setting DMA mask fails
  2019-07-16 17:15 [PATCH] dmaengine: bcm2835: Print error in case setting DMA mask fails Stefan Wahren
@ 2019-07-22 14:26 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-07-22 14:26 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Dan Williams, Eric Anholt, Florian Fainelli, Ray Jui,
	Scott Branden, bcm-kernel-feedback-list, dmaengine,
	linux-arm-kernel, linux-rpi-kernel, linux-kernel

On 16-07-19, 19:15, Stefan Wahren wrote:
> During enabling of the RPi 4, we found out that the driver doesn't provide
> a helpful error message in case setting DMA mask fails. So add one.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 17:15 [PATCH] dmaengine: bcm2835: Print error in case setting DMA mask fails Stefan Wahren
2019-07-22 14:26 ` Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org dmaengine@archiver.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/ public-inbox