dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3 03/24] dmaengine: imx-sdma: Remove call to memset after dma_alloc_coherent
@ 2019-07-15  3:17 Fuqian Huang
  2019-08-08 12:22 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Fuqian Huang @ 2019-07-15  3:17 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: Vinod Koul, Shawn Guo, Sascha Hauer, dmaengine, linux-arm-kernel,
	linux-kernel, Fuqian Huang

In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
Changes in v3:
  - Use actual commit rather than the merge commit in the commit message

 drivers/dma/imx-sdma.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 4ec84a633bd3..decfb9e9648a 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1886,10 +1886,6 @@ static int sdma_init(struct sdma_engine *sdma)
 	sdma->context_phys = ccb_phys +
 		MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control);
 
-	/* Zero-out the CCB structures array just allocated */
-	memset(sdma->channel_control, 0,
-			MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control));
-
 	/* disable all channels */
 	for (i = 0; i < sdma->drvdata->num_events; i++)
 		writel_relaxed(0, sdma->regs + chnenbl_ofs(sdma, i));
-- 
2.11.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 03/24] dmaengine: imx-sdma: Remove call to memset after dma_alloc_coherent
  2019-07-15  3:17 [PATCH v3 03/24] dmaengine: imx-sdma: Remove call to memset after dma_alloc_coherent Fuqian Huang
@ 2019-08-08 12:22 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-08-08 12:22 UTC (permalink / raw)
  To: Fuqian Huang
  Cc: Shawn Guo, Sascha Hauer, dmaengine, linux-arm-kernel, linux-kernel

On 15-07-19, 11:17, Fuqian Huang wrote:
> In commit 518a2f1925c3
> ("dma-mapping: zero memory returned from dma_alloc_*"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15  3:17 [PATCH v3 03/24] dmaengine: imx-sdma: Remove call to memset after dma_alloc_coherent Fuqian Huang
2019-08-08 12:22 ` Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org dmaengine@archiver.kernel.org
	public-inbox-index dmaengine


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/ public-inbox