From: Vinod Koul <vkoul@kernel.org>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: dan.j.williams@intel.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, dmaengine@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: stm32-mdma: Fix a possible null-pointer dereference in stm32_mdma_irq_handler()
Date: Thu, 8 Aug 2019 18:54:56 +0530 [thread overview]
Message-ID: <20190808132456.GA12733@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20190729020849.17971-1-baijiaju1990@gmail.com>
On 29-07-19, 10:08, Jia-Ju Bai wrote:
> In stm32_mdma_irq_handler(), chan is checked on line 1368.
> When chan is NULL, it is still used on line 1369:
> dev_err(chan2dev(chan), "MDMA channel not initialized\n");
>
> Thus, a possible null-pointer dereference may occur.
>
> To fix this bug, "dev_dbg(mdma2dev(dmadev), ...)" is used instead.
Applied after changing subsystem name in patch title to dmaengine: ...,
Also while fixing it helps to add Fixes tag, have added
Thanks
--
~Vinod
prev parent reply other threads:[~2019-08-08 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 2:08 [PATCH] dma: stm32-mdma: Fix a possible null-pointer dereference in stm32_mdma_irq_handler() Jia-Ju Bai
2019-08-08 13:24 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808132456.GA12733@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=baijiaju1990@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).