From: Vinod Koul <vkoul@kernel.org>
To: Mao Wenan <maowenan@huawei.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH linux-next] drivers: dma: Fix sparse warning for mux_configure32
Date: Tue, 13 Aug 2019 10:13:27 +0530 [thread overview]
Message-ID: <20190813044327.GR12733@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20190812074205.96759-1-maowenan@huawei.com>
On 12-08-19, 15:42, Mao Wenan wrote:
Patch title is incorrect, it should mention the changes in patch, for
example make mux_configure32 static
Do read up on Documentation/process/submitting-patches.rst again!
> There is one sparse warning in drivers/dma/fsl-edma-common.c,
It will help to explain the warning before the fix
> fix it by setting mux_configure32() as static.
>
> make allmodconfig ARCH=mips CROSS_COMPILE=mips-linux-gnu-
> make C=2 drivers/dma/fsl-edma-common.o ARCH=mips CROSS_COMPILE=mips-linux-gnu-
Make cmds are not relevant for the log
> drivers/dma/fsl-edma-common.c:93:6: warning: symbol 'mux_configure32' was not declared. Should it be static?
This one is and should be retained
>
> Fixes: 232a7f18cf8ec ("dmaengine: fsl-edma: add i.mx7ulp edma2 version support")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/dma/fsl-edma-common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
> index 6d6d8a4..7dbf7df 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -90,8 +90,8 @@ static void mux_configure8(struct fsl_edma_chan *fsl_chan, void __iomem *addr,
> iowrite8(val8, addr + off);
> }
>
> -void mux_configure32(struct fsl_edma_chan *fsl_chan, void __iomem *addr,
> - u32 off, u32 slot, bool enable)
> +static void mux_configure32(struct fsl_edma_chan *fsl_chan, void __iomem *addr,
just change this to static
> + u32 off, u32 slot, bool enable)
and dont change anything else.
If you feel to change this, propose a new patch for this line explaining
why this should be changed
> {
> u32 val;
>
> --
> 2.7.4
--
~Vinod
next prev parent reply other threads:[~2019-08-13 4:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 7:42 [PATCH linux-next] drivers: dma: Fix sparse warning for mux_configure32 Mao Wenan
2019-08-13 4:43 ` Vinod Koul [this message]
2019-08-14 2:40 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813044327.GR12733@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).