From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2426C3A589 for ; Tue, 20 Aug 2019 11:45:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82BD822CF7 for ; Tue, 20 Aug 2019 11:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566301517; bh=0lT4v0LX5pXjxpd6d87L+ufuAZo4ezWjtwt8ULNdJPc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qPuh+qQNBkchnqswB1psGXSiKNYZONKVQAaCH6iGjK5p8YmmbAigBEGxhFfQnrH5r krP4ZPk3RQacsvvWiFU75pfPaEoczq+SJpW92rnec8ak25C6/K9ISZzOTn6fNKUtj7 +PNS2jTK0dmjAwATF4pHFgN6mC3StVi2XrSxSx6c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728409AbfHTLpR (ORCPT ); Tue, 20 Aug 2019 07:45:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:47126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729574AbfHTLpR (ORCPT ); Tue, 20 Aug 2019 07:45:17 -0400 Received: from localhost (unknown [106.201.62.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CD5C22CE3; Tue, 20 Aug 2019 11:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566301516; bh=0lT4v0LX5pXjxpd6d87L+ufuAZo4ezWjtwt8ULNdJPc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fDMllfagwKR8/yMdUxTCr+elQziywK4erQs3BAm7X1MV4qGn5c4YYxwVNB79ZxSt1 fGQxFMaJMOKTxT3jVgRlowh/ueYII+COBETOpzG2HRuXis4+qF3TSeRHI/juwti0jp Bxoiih4+OKFKAyQnhv7Jl7N5tu0KkSjElIyPf/ac= Date: Tue, 20 Aug 2019 17:14:05 +0530 From: Vinod Koul To: Wenwen Wang Cc: Dan Williams , Enrico Weigelt , Allison Randal , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , open list Subject: Re: [PATCH] dmaengine: ti: omap-dma: Add cleanup in omap_dma_probe() Message-ID: <20190820114405.GY12733@vkoul-mobl.Dlink> References: <1565938570-7528-1-git-send-email-wenwen@cs.uga.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565938570-7528-1-git-send-email-wenwen@cs.uga.edu> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 16-08-19, 01:56, Wenwen Wang wrote: > If devm_request_irq() fails to disable all interrupts, no cleanup is > performed before retuning the error. To fix this issue, invoke > omap_dma_free() to do the cleanup. Applied, thanks -- ~Vinod