From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D87A6C3A59E for ; Tue, 20 Aug 2019 13:45:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A482122DBF for ; Tue, 20 Aug 2019 13:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566308746; bh=LW5qp6XfuJjAUPUHUn97SNKsVsQxthcEcjLQxHBB148=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=05CNyM2Ldmj8dC4wabG9oHwnJdtcUiDSyk69Rd30EwJDnaNgeygInt/5KgVC8tLNq D689ZE5OpW9KNgYkP4PadoYIO6WSa9/pk7TYE/D4ufBsIK1jOmLzr7R9kZ/ijybc83 cr5GHDD3G0v7c5bBMOSUMnHmwCNYBo3JnlZWlN9k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730645AbfHTNm3 (ORCPT ); Tue, 20 Aug 2019 09:42:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:37820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730224AbfHTNm3 (ORCPT ); Tue, 20 Aug 2019 09:42:29 -0400 Received: from sasha-vm.mshome.net (unknown [12.236.144.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 442D02332B; Tue, 20 Aug 2019 13:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566308548; bh=LW5qp6XfuJjAUPUHUn97SNKsVsQxthcEcjLQxHBB148=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L/IqDaEfdweexTHaUkc4X8ffGSCsV5LDv2cDZnoZYRiG+WU7gQ+DknOhF1hwt14r/ lFoLoN6O4R4mqOP/LCdA3hKABsIdpnWM1TdyKxiXlv0Fqi4ULaKRlunrcTJLl2XTC8 H0UYHfazY0nIY0s8UZjlPb+7wuUTt5Y4CxB6S6xE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , Vinod Koul , Sasha Levin , dmaengine@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 15/27] dmaengine: stm32-mdma: Fix a possible null-pointer dereference in stm32_mdma_irq_handler() Date: Tue, 20 Aug 2019 09:42:01 -0400 Message-Id: <20190820134213.11279-15-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190820134213.11279-1-sashal@kernel.org> References: <20190820134213.11279-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org From: Jia-Ju Bai [ Upstream commit 39c71a5b8212f4b502d9a630c6706ac723abd422 ] In stm32_mdma_irq_handler(), chan is checked on line 1368. When chan is NULL, it is still used on line 1369: dev_err(chan2dev(chan), "MDMA channel not initialized\n"); Thus, a possible null-pointer dereference may occur. To fix this bug, "dev_dbg(mdma2dev(dmadev), ...)" is used instead. Signed-off-by: Jia-Ju Bai Fixes: a4ffb13c8946 ("dmaengine: Add STM32 MDMA driver") Link: https://lore.kernel.org/r/20190729020849.17971-1-baijiaju1990@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/stm32-mdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c index 06dd1725375e5..8c3c3e5b812a8 100644 --- a/drivers/dma/stm32-mdma.c +++ b/drivers/dma/stm32-mdma.c @@ -1376,7 +1376,7 @@ static irqreturn_t stm32_mdma_irq_handler(int irq, void *devid) chan = &dmadev->chan[id]; if (!chan) { - dev_err(chan2dev(chan), "MDMA channel not initialized\n"); + dev_dbg(mdma2dev(dmadev), "MDMA channel not initialized\n"); goto exit; } -- 2.20.1