* [PATCH -next] dmaengine: iop-adma: remove set but not used variable 'slots_per_op'
@ 2019-08-21 12:19 YueHaibing
2019-09-04 4:45 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-08-21 12:19 UTC (permalink / raw)
To: dan.j.williams, vkoul, arnd; +Cc: linux-kernel, dmaengine, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/dma/iop-adma.c: In function iop_adma_tx_submit:
drivers/dma/iop-adma.c:367:6: warning:
variable slots_per_op set but not used [-Wunused-but-set-variable]
It is never used, so can be removed.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/dma/iop-adma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c
index 03f4a58..0dab7b7 100644
--- a/drivers/dma/iop-adma.c
+++ b/drivers/dma/iop-adma.c
@@ -364,13 +364,11 @@ iop_adma_tx_submit(struct dma_async_tx_descriptor *tx)
struct iop_adma_chan *iop_chan = to_iop_adma_chan(tx->chan);
struct iop_adma_desc_slot *grp_start, *old_chain_tail;
int slot_cnt;
- int slots_per_op;
dma_cookie_t cookie;
dma_addr_t next_dma;
grp_start = sw_desc->group_head;
slot_cnt = grp_start->slot_cnt;
- slots_per_op = grp_start->slots_per_op;
spin_lock_bh(&iop_chan->lock);
cookie = dma_cookie_assign(tx);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] dmaengine: iop-adma: remove set but not used variable 'slots_per_op'
2019-08-21 12:19 [PATCH -next] dmaengine: iop-adma: remove set but not used variable 'slots_per_op' YueHaibing
@ 2019-09-04 4:45 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-09-04 4:45 UTC (permalink / raw)
To: YueHaibing; +Cc: dan.j.williams, arnd, linux-kernel, dmaengine
On 21-08-19, 20:19, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/dma/iop-adma.c: In function iop_adma_tx_submit:
> drivers/dma/iop-adma.c:367:6: warning:
> variable slots_per_op set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-04 4:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 12:19 [PATCH -next] dmaengine: iop-adma: remove set but not used variable 'slots_per_op' YueHaibing
2019-09-04 4:45 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).