dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] IOAT: iop-adma.c: fix printk format warning
       [not found] <138f82a9-08ad-2bb2-cfce-f3124ec502fc@infradead.org>
@ 2019-08-30 21:44 ` Dan Williams
  2019-09-04  4:58   ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2019-08-30 21:44 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: LKML, Vinod Koul, dmaengine

[ add Vinod and dmaengine ]

On Fri, Aug 30, 2019 at 2:32 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix printk format warning in iop-adma.c (seen on x86_64) by using
> %pad:
>
> ../drivers/dma/iop-adma.c:118:12: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t {aka long long unsigned int}’ [-Wformat=]
>
> Fixes: c211092313b9 ("dmaengine: driver for the iop32x, iop33x, and iop13xx raid engines")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dan Williams <dan.j.williams@intel.com>

Acked-by: Dan Williams <dan.j.williams@intel.com>

> ---
>  drivers/dma/iop-adma.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20190830.orig/drivers/dma/iop-adma.c
> +++ linux-next-20190830/drivers/dma/iop-adma.c
> @@ -116,9 +116,9 @@ static void __iop_adma_slot_cleanup(stru
>         list_for_each_entry_safe(iter, _iter, &iop_chan->chain,
>                                         chain_node) {
>                 pr_debug("\tcookie: %d slot: %d busy: %d "
> -                       "this_desc: %#x next_desc: %#llx ack: %d\n",
> +                       "this_desc: %pad next_desc: %#llx ack: %d\n",
>                         iter->async_tx.cookie, iter->idx, busy,
> -                       iter->async_tx.phys, (u64)iop_desc_get_next_desc(iter),
> +                       &iter->async_tx.phys, (u64)iop_desc_get_next_desc(iter),
>                         async_tx_test_ack(&iter->async_tx));
>                 prefetch(_iter);
>                 prefetch(&_iter->async_tx);
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] IOAT: iop-adma.c: fix printk format warning
  2019-08-30 21:44 ` [PATCH] IOAT: iop-adma.c: fix printk format warning Dan Williams
@ 2019-09-04  4:58   ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-09-04  4:58 UTC (permalink / raw)
  To: Dan Williams; +Cc: Randy Dunlap, LKML, dmaengine

On 30-08-19, 14:44, Dan Williams wrote:
> [ add Vinod and dmaengine ]
> 
> On Fri, Aug 30, 2019 at 2:32 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > Fix printk format warning in iop-adma.c (seen on x86_64) by using
> > %pad:
> >
> > ../drivers/dma/iop-adma.c:118:12: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t {aka long long unsigned int}’ [-Wformat=]

This doesnt apply for me. Please rebase on next and resend with Dan's
ack

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <138f82a9-08ad-2bb2-cfce-f3124ec502fc@infradead.org>
2019-08-30 21:44 ` [PATCH] IOAT: iop-adma.c: fix printk format warning Dan Williams
2019-09-04  4:58   ` Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org dmaengine@archiver.kernel.org
	public-inbox-index dmaengine


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/ public-inbox