From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52FAC4740A for ; Mon, 9 Sep 2019 22:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B50C2171F for ; Mon, 9 Sep 2019 22:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568067469; bh=8Ay5QZRIfx6Enn7YintV43y+fPovqavXMA0bfouCU1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AtM7mww/FEI++NHb27xTpUGKT+7svTGjxRvU3FkDJpBfK4/au+/pOi06TdZLURfDo n+m/hpXLdKtGq69YzxCP3fdr375ej0ekgQR3MIradFjk5R7CGCU6HOUIk2B0Cak1YF LQ3QNJpvcemzzHAb2iqk/7C9f0gfBa0GYMX+mqQs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392274AbfIIWRW (ORCPT ); Mon, 9 Sep 2019 18:17:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:46480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392262AbfIIWRU (ORCPT ); Mon, 9 Sep 2019 18:17:20 -0400 Received: from sasha-vm.mshome.net (unknown [62.28.240.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B5F1222C4; Mon, 9 Sep 2019 22:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568067439; bh=8Ay5QZRIfx6Enn7YintV43y+fPovqavXMA0bfouCU1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bJGAS4PMi4E2Yjng1XGqxZH/WaIKdk+ONsId/WHQs8vfYwut6iCN72TqHMBphboDN wo9ytmIBv35rMOblvB2h9kHRfOpO7YsrswlxON0WxLUw/y3BQYNXBsbhprJ+nzumL2 obPz8m7HgIFJRlAIPKvQX1Fb/yGVaEdWOrocxmu8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wenwen Wang , Peter Ujfalusi , Vinod Koul , Sasha Levin , dmaengine@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 2/6] dmaengine: ti: omap-dma: Add cleanup in omap_dma_probe() Date: Mon, 9 Sep 2019 11:42:01 -0400 Message-Id: <20190909154205.31376-2-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190909154205.31376-1-sashal@kernel.org> References: <20190909154205.31376-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org From: Wenwen Wang [ Upstream commit 962411b05a6d3342aa649e39cda1704c1fc042c6 ] If devm_request_irq() fails to disable all interrupts, no cleanup is performed before retuning the error. To fix this issue, invoke omap_dma_free() to do the cleanup. Signed-off-by: Wenwen Wang Acked-by: Peter Ujfalusi Link: https://lore.kernel.org/r/1565938570-7528-1-git-send-email-wenwen@cs.uga.edu Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/omap-dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c index 6b16ce390dce1..9f901f16bddcd 100644 --- a/drivers/dma/omap-dma.c +++ b/drivers/dma/omap-dma.c @@ -1429,8 +1429,10 @@ static int omap_dma_probe(struct platform_device *pdev) rc = devm_request_irq(&pdev->dev, irq, omap_dma_irq, IRQF_SHARED, "omap-dma-engine", od); - if (rc) + if (rc) { + omap_dma_free(od); return rc; + } } if (omap_dma_glbl_read(od, CAPS_0) & CAPS_0_SUPPORT_LL123) -- 2.20.1