dmaengine Archive on lore.kernel.org
 help / color / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: vinod.koul@intel.com, dmaengine@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 3/4] dmaengine: rcar-dmac: Use devm_platform_ioremap_resource()
Date: Fri, 13 Sep 2019 10:46:51 +0200
Message-ID: <20190913084651.ggmrs6nyxalqr3jc@verge.net.au> (raw)
In-Reply-To: <1568010892-17606-4-git-send-email-yoshihiro.shimoda.uh@renesas.com>

On Mon, Sep 09, 2019 at 03:34:51PM +0900, Yoshihiro Shimoda wrote:
> This patch uses devm_platform_ioremap_resource() instead of
> using platform_get_resource() and devm_ioremap_resource() together
> to simplify.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  drivers/dma/sh/rcar-dmac.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index 74996a0..542786d 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -1824,7 +1824,6 @@ static int rcar_dmac_probe(struct platform_device *pdev)
>  	struct dma_device *engine;
>  	struct rcar_dmac *dmac;
>  	const struct rcar_dmac_of_data *data;
> -	struct resource *mem;
>  	unsigned int i;
>  	int ret;
>  
> @@ -1863,8 +1862,7 @@ static int rcar_dmac_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	/* Request resources. */
> -	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	dmac->iomem = devm_ioremap_resource(&pdev->dev, mem);
> +	dmac->iomem = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(dmac->iomem))
>  		return PTR_ERR(dmac->iomem);
>  
> -- 
> 2.7.4
> 

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09  6:34 [PATCH v3 0/4] dmaengine: rcar-dmac: use of_data and add dma-channel-mask support Yoshihiro Shimoda
2019-09-09  6:34 ` [PATCH v3 1/4] dmaengine: rcar-dmac: Fix DMACHCLR handling if iommu is mapped Yoshihiro Shimoda
2019-09-09  6:34 ` [PATCH v3 2/4] dmaengine: rcar-dmac: Use of_data values instead of a macro Yoshihiro Shimoda
2019-09-13  8:48   ` Simon Horman
2019-09-09  6:34 ` [PATCH v3 3/4] dmaengine: rcar-dmac: Use devm_platform_ioremap_resource() Yoshihiro Shimoda
2019-09-13  8:46   ` Simon Horman [this message]
2019-09-09  6:34 ` [PATCH v3 4/4] dmaengine: rcar-dmac: Add dma-channel-mask property support Yoshihiro Shimoda
2019-10-14  6:58 ` [PATCH v3 0/4] dmaengine: rcar-dmac: use of_data and add dma-channel-mask support Vinod Koul

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190913084651.ggmrs6nyxalqr3jc@verge.net.au \
    --to=horms@verge.net.au \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git