From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4945C4740C for ; Sun, 22 Sep 2019 19:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B45BD2067B for ; Sun, 22 Sep 2019 19:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569180055; bh=XgrJTEr1zHVb1qydoT2TySsbUVaRZlc38KN9JrnviyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=y3yW5nC8VYNXNdFhNCKzGuVX+SBKwtjhEhc+PJ4XDjDTOAXpzDLfp4PnInv12a5tP xNuvdybldQptdba8N5STmHqg416ZV8PFTLP5aZNJ7fYILcNg1DDm8xttQDo08lgMoW ewDiEtZpatAGPQ29wohqqnydIARPAyyzmtffa7OE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730992AbfIVTUu (ORCPT ); Sun, 22 Sep 2019 15:20:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:54988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405189AbfIVSy2 (ORCPT ); Sun, 22 Sep 2019 14:54:28 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09A1921BE5; Sun, 22 Sep 2019 18:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178467; bh=XgrJTEr1zHVb1qydoT2TySsbUVaRZlc38KN9JrnviyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UoUStBkOQ1PE276fEKKOc7AcA+90zVjhs75lfq2vpqLMiJa0Iczeqc8lViv7OAkE7 5Zd70yusr4a2F4zkEKGRMSObO/3Qx2Aqy5nBQ60viPLU/+tK66kJDZZ9tTjxcE2vS/ R8sPpTjFMk61aR7E5YfNXuanNQCl86fWI/6hqCPE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Stefan Wahren , Vinod Koul , Sasha Levin , dmaengine@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 007/128] dmaengine: bcm2835: Print error in case setting DMA mask fails Date: Sun, 22 Sep 2019 14:52:17 -0400 Message-Id: <20190922185418.2158-7-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922185418.2158-1-sashal@kernel.org> References: <20190922185418.2158-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org From: Stefan Wahren [ Upstream commit 72503b25ee363827aafffc3e8d872e6a92a7e422 ] During enabling of the RPi 4, we found out that the driver doesn't provide a helpful error message in case setting DMA mask fails. So add one. Signed-off-by: Stefan Wahren Link: https://lore.kernel.org/r/1563297318-4900-1-git-send-email-wahrenst@gmx.net Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/bcm2835-dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index 2b11d967acd02..9d782cc95c6a0 100644 --- a/drivers/dma/bcm2835-dma.c +++ b/drivers/dma/bcm2835-dma.c @@ -898,8 +898,10 @@ static int bcm2835_dma_probe(struct platform_device *pdev) pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask; rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); - if (rc) + if (rc) { + dev_err(&pdev->dev, "Unable to set DMA mask\n"); return rc; + } od = devm_kzalloc(&pdev->dev, sizeof(*od), GFP_KERNEL); if (!od) -- 2.20.1