From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D324BC432C1 for ; Tue, 24 Sep 2019 16:38:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5437214AF for ; Tue, 24 Sep 2019 16:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569343127; bh=SljDFFMo90crqwi671Z3O1CEkHPiBtOHyj4ru/WL+RE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1tE08d18+ygS5NDO8olhipqSHqEVZoUaldu4V8zrBGNIiRMAY7EHEkUWkwsS8kCoO BFB66grWBysCmTl8shcpwd5T62evHGawZ2YMY+LHh4UECeKLMOza4u8kD4siv5SXmD IF1SZsgctKp2glr20Wwme5xVgOZtgGMKzegQSvLM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbfIXQir (ORCPT ); Tue, 24 Sep 2019 12:38:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:56794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725208AbfIXQiq (ORCPT ); Tue, 24 Sep 2019 12:38:46 -0400 Received: from localhost (unknown [12.157.10.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F357A20872; Tue, 24 Sep 2019 16:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569343126; bh=SljDFFMo90crqwi671Z3O1CEkHPiBtOHyj4ru/WL+RE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MJtsyQR/QJh5MBrSmme4Yi4JJeupeEh5dasYT1OYhrA8RDK70k+BAF6YqccEpZarI 1d7xI1+VwKxRJJmjWBE/cQAHwNdbBWOsu96uCluF8eottaxzEO5/27sv+A/CATMJix UeVIBUoCb5IXuoMGXuaPVSzfN9VMnlR2UiVR4IFo= Date: Tue, 24 Sep 2019 09:37:44 -0700 From: Vinod Koul To: "Mehta, Sanju" Cc: "S-k, Shyam-sundar" , "Shah, Nehal-bakulchandra" , "Kumar, Rajesh" , "mchehab+samsung@kernel.org" , "davem@davemloft.net" , "gregkh@linuxfoundation.org" , "robh@kernel.org" , "linus.walleij@linaro.org" , "nicolas.ferre@microchip.com" , "dan.j.williams@intel.com" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" Subject: Re: [PATCH 0/4] *** AMD PTDMA driver *** Message-ID: <20190924163744.GC3824@vkoul-mobl> References: <1569310236-29113-1-git-send-email-Sanju.Mehta@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1569310236-29113-1-git-send-email-Sanju.Mehta@amd.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 24-09-19, 07:31, Mehta, Sanju wrote: > From: Sanjay R Mehta > > *** This patch series adds support for AMD PTDMA engine *** What lots of stars! Can you describe the controller a bit more to help people set the context for the review! And also helps to make the email subject as "Add AMD PTDMA driver ...." or similar! > > Sanjay R Mehta (4): > dma: Add PTDMA Engine driver support > dma: Support for multiple PTDMA > dmaengine: Register as a DMA resource > dmaengine: Add debugfs entries for PTDMA information Can you be consistent with naming, and yes do use dmaengine! > > MAINTAINERS | 6 + > drivers/dma/Kconfig | 2 + > drivers/dma/Makefile | 1 + > drivers/dma/ptdma/Kconfig | 8 + > drivers/dma/ptdma/Makefile | 12 + > drivers/dma/ptdma/ptdma-debugfs.c | 249 +++++++++++++ > drivers/dma/ptdma/ptdma-dev.c | 445 +++++++++++++++++++++++ > drivers/dma/ptdma/ptdma-dmaengine.c | 700 ++++++++++++++++++++++++++++++++++++ > drivers/dma/ptdma/ptdma-ops.c | 464 ++++++++++++++++++++++++ > drivers/dma/ptdma/ptdma-pci.c | 244 +++++++++++++ > drivers/dma/ptdma/ptdma.h | 563 +++++++++++++++++++++++++++++ > 11 files changed, 2694 insertions(+) > create mode 100644 drivers/dma/ptdma/Kconfig > create mode 100644 drivers/dma/ptdma/Makefile > create mode 100644 drivers/dma/ptdma/ptdma-debugfs.c > create mode 100644 drivers/dma/ptdma/ptdma-dev.c > create mode 100644 drivers/dma/ptdma/ptdma-dmaengine.c > create mode 100644 drivers/dma/ptdma/ptdma-ops.c > create mode 100644 drivers/dma/ptdma/ptdma-pci.c > create mode 100644 drivers/dma/ptdma/ptdma.h > > -- > 2.7.4 -- ~Vinod