From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E99C47404 for ; Mon, 14 Oct 2019 05:03:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E597920882 for ; Mon, 14 Oct 2019 05:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571029400; bh=mS3CctfHD5469kRjRuKvd4vU4oRhuSk3zV0oFGa4ofA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OtDgoN8hy5fIMiBXc3qwHwC6ynp+CgLkiA8UO2cjNpypJkOIogJ1mprLc/ufUSKcy 1QzqrFzAbKgXzYYKU3JPzGBVLKOch5pBLGJAsVDlp47932D60s8H4rMOjWfirEzfxS DRywMCL4nN+9VcRFepgyzNHz7lf2mfFc4mXi29II= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725877AbfJNFDT (ORCPT ); Mon, 14 Oct 2019 01:03:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:42994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725787AbfJNFDT (ORCPT ); Mon, 14 Oct 2019 01:03:19 -0400 Received: from localhost (unknown [122.167.124.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 088582083B; Mon, 14 Oct 2019 05:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571029398; bh=mS3CctfHD5469kRjRuKvd4vU4oRhuSk3zV0oFGa4ofA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VbJ9AGyAQP8GZ230tH1AG7Q+XwfKF/s5qTtLar9YnWluOrL9C77A7pwWqlTaLufPc VlYpkRbD+uJaciceRpH7QjnUAvITd67hF44RNJBmyfaCxG5VwjOI9YsQI3jCcouyF5 jb1S7qh+8XUws3v6TYsdGvS4K6pD/iIA9pvUV6pk= Date: Mon, 14 Oct 2019 10:33:13 +0530 From: Vinod Koul To: Baolin Wang Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, eric.long@unisoc.com, zhenfang.wang@unisoc.com Subject: Re: [PATCH] dmaengine: sprd: Fix the link-list pointer register configuration issue Message-ID: <20191014050313.GG27950@vkoul-mobl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 12-09-19, 13:47, Baolin Wang wrote: > From: Zhenfang Wang > > We will set the link-list pointer register point to next link-list > configuration's physical address, which can load DMA configuration > from the link-list node automatically. > > But the link-list node's physical address can be larger than 32bits, > and now Spreadtrum DMA driver only supports 32bits physical address, > which may cause loading a incorrect DMA configuration when starting > the link-list transfer mode. According to the DMA datasheet, we can > use SRC_BLK_STEP register (bit28 - bit31) to save the high bits of the > link-list node's physical address to fix this issue. Applied, thanks -- ~Vinod