* [PATCH] dmaengine: owl: Use devm_platform_ioremap_resource() in owl_dma_probe()
@ 2019-09-22 11:30 Markus Elfring
2019-10-14 7:52 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2019-09-22 11:30 UTC (permalink / raw)
To: dmaengine, linux-arm-kernel, Andreas Färber, Dan Williams,
Manivannan Sadhasivam, Vinod Koul
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 22 Sep 2019 13:23:54 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/dma/owl-dma.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
index 90bbcef99ef8..023f951189a7 100644
--- a/drivers/dma/owl-dma.c
+++ b/drivers/dma/owl-dma.c
@@ -1045,18 +1045,13 @@ static int owl_dma_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
struct owl_dma *od;
- struct resource *res;
int ret, i, nr_channels, nr_requests;
od = devm_kzalloc(&pdev->dev, sizeof(*od), GFP_KERNEL);
if (!od)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -EINVAL;
-
- od->base = devm_ioremap_resource(&pdev->dev, res);
+ od->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(od->base))
return PTR_ERR(od->base);
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: owl: Use devm_platform_ioremap_resource() in owl_dma_probe()
2019-09-22 11:30 [PATCH] dmaengine: owl: Use devm_platform_ioremap_resource() in owl_dma_probe() Markus Elfring
@ 2019-10-14 7:52 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-10-14 7:52 UTC (permalink / raw)
To: Markus Elfring
Cc: dmaengine, linux-arm-kernel, Andreas Färber, Dan Williams,
Manivannan Sadhasivam, LKML, kernel-janitors
On 22-09-19, 13:30, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 22 Sep 2019 13:23:54 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-14 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-22 11:30 [PATCH] dmaengine: owl: Use devm_platform_ioremap_resource() in owl_dma_probe() Markus Elfring
2019-10-14 7:52 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).