From: Vinod Koul <vkoul@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com,
dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, eric.long@unisoc.com,
zhenfang.wang@unisoc.com
Subject: Re: [PATCH] dmaengine: sprd: Fix the possible memory leak issue
Date: Tue, 15 Oct 2019 15:47:34 +0530 [thread overview]
Message-ID: <20191015101734.GS2654@vkoul-mobl> (raw)
In-Reply-To: <170dbbc6d5366b6fa974ce2d366652e23a334251.1570609788.git.baolin.wang@linaro.org>
On 09-10-19, 17:11, Baolin Wang wrote:
> If we terminate the channel to free all descriptors associated with this
> channel, we will leak the memory of current descriptor if the current
> descriptor is not completed, since it had been deteled from the desc_issued
> list and have not been added into the desc_completed list.
>
> Thus we should check if current descriptor is completed or not, when freeing
> the descriptors associated with one channel, if not, we should free it to
> avoid this issue.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2019-10-15 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 9:11 [PATCH] dmaengine: sprd: Fix the possible memory leak issue Baolin Wang
2019-10-15 10:17 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015101734.GS2654@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.long@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
--cc=zhenfang.wang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).