From: Vinod Koul <vkoul@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>,
dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org,
miquel.raynal@bootlin.com, bth@kamstrup.com,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: Regression: dmaengine: imx28 with emmc
Date: Thu, 17 Oct 2019 18:29:58 +0530 [thread overview]
Message-ID: <20191017125958.GO2654@vkoul-mobl> (raw)
In-Reply-To: <20191014141344.uwnzy3j3kxngzv7a@pengutronix.de>
On 14-10-19, 16:13, Sascha Hauer wrote:
> Hi Bruno,
>
> On Tue, Oct 08, 2019 at 10:03:16AM +0200, Bruno Thomsen wrote:
> > Hi
> >
> > I am getting a kernel oops[1] during boot on imx28 with emmc flash right
> > around rootfs mounting. Using git bisect I found the cause to be the
> > following commit.
> >
> > Regression: ceeeb99cd821 ("dmaengine: mxs: rename custom flag")
> >
> > Reverting the 2 changes in drivers/dma/mxs-dma.c fixes the oops,
> > but I am not sure that is the right solution as I don't have the full
> > mxs-dma + mtd/mmc overview.
> >
> > I did see that the patch isn't a simple rename but also a bit define
> > change.
> > From: DMA_CTRL_ACK = (1 << 1) = BIT(1)
> > To: MXS_DMA_CTRL_WAIT4END = BIT(31)
> >
>
> Damn, I wasn't aware the DMA driver has other users than the GPMI Nand.
> Please try the attached patch, it should fix it for MMC/SD. It seems
> however, that I2C and AUART and SPI are also affected. Are you able to
> test any of these?
>
> Sascha
>
> ---------------------------8<---------------------------
>
> >From 3f7a1097099c9e57e31a86503edc479f9964bc95 Mon Sep 17 00:00:00 2001
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Date: Mon, 14 Oct 2019 16:07:31 +0200
> Subject: [PATCH] mmc: mxs: fix flags passed to dmaengine_prep_slave_sg
>
> Since ceeeb99cd821 we no longer abuse the DMA_CTRL_ACK flag for custom
> driver use and introduced the MXS_DMA_CTRL_WAIT4END instead. We have not
> changed all users to this flag though. This patch fixes it for the
> mxs-mmc driver.
lgtm, this should be submitted to mmc folks
>
> Fixes: ceeeb99cd821 ("dmaengine: mxs: rename custom flag")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mmc/host/mxs-mmc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index 78e7e350655c..4031217d21c3 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -17,6 +17,7 @@
> #include <linux/interrupt.h>
> #include <linux/dma-mapping.h>
> #include <linux/dmaengine.h>
> +#include <linux/dma/mxs-dma.h>
> #include <linux/highmem.h>
> #include <linux/clk.h>
> #include <linux/err.h>
> @@ -266,7 +267,7 @@ static void mxs_mmc_bc(struct mxs_mmc_host *host)
> ssp->ssp_pio_words[2] = cmd1;
> ssp->dma_dir = DMA_NONE;
> ssp->slave_dirn = DMA_TRANS_NONE;
> - desc = mxs_mmc_prep_dma(host, DMA_CTRL_ACK);
> + desc = mxs_mmc_prep_dma(host, MXS_DMA_CTRL_WAIT4END);
> if (!desc)
> goto out;
>
> @@ -311,7 +312,7 @@ static void mxs_mmc_ac(struct mxs_mmc_host *host)
> ssp->ssp_pio_words[2] = cmd1;
> ssp->dma_dir = DMA_NONE;
> ssp->slave_dirn = DMA_TRANS_NONE;
> - desc = mxs_mmc_prep_dma(host, DMA_CTRL_ACK);
> + desc = mxs_mmc_prep_dma(host, MXS_DMA_CTRL_WAIT4END);
> if (!desc)
> goto out;
>
> @@ -441,7 +442,7 @@ static void mxs_mmc_adtc(struct mxs_mmc_host *host)
> host->data = data;
> ssp->dma_dir = dma_data_dir;
> ssp->slave_dirn = slave_dirn;
> - desc = mxs_mmc_prep_dma(host, DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
> + desc = mxs_mmc_prep_dma(host, DMA_PREP_INTERRUPT | MXS_DMA_CTRL_WAIT4END);
> if (!desc)
> goto out;
>
> --
> 2.23.0
>
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
~Vinod
next prev parent reply other threads:[~2019-10-17 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 8:03 Regression: dmaengine: imx28 with emmc Bruno Thomsen
2019-10-14 14:13 ` Sascha Hauer
2019-10-17 11:30 ` Bruno Thomsen
2019-10-17 12:41 ` Fabio Estevam
2019-10-17 12:59 ` Vinod Koul [this message]
2019-10-18 9:50 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017125958.GO2654@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=bruno.thomsen@gmail.com \
--cc=bth@kamstrup.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).