From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5228ACA9EAE for ; Wed, 23 Oct 2019 05:09:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2578121906 for ; Wed, 23 Oct 2019 05:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571807375; bh=yHRR1qaWgApvonMqA4KR2biBOE3OmpEgupa0lezkM0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KInJNd4ma4Gdpr1lCTdEK7TJXbsjeLV04gEhhlUBEprxETS0pOAjzfy7y7y9FKHlz wCAqpI6GYEmKHJ/zWaH8KeTSaxPgiOT+AIv9JRghiChWxr6WmmTZ8Lki6mHgaQJTSg yITaMnNTHJcFHAkw1VWz4Ml+4fYPzDoy+XXaCLG4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731525AbfJWFJe (ORCPT ); Wed, 23 Oct 2019 01:09:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:35852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728697AbfJWFJe (ORCPT ); Wed, 23 Oct 2019 01:09:34 -0400 Received: from localhost (unknown [122.181.210.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FFD4214B2; Wed, 23 Oct 2019 05:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571807374; bh=yHRR1qaWgApvonMqA4KR2biBOE3OmpEgupa0lezkM0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R21h/IlOeR/5NGFmEipA8/XzUX9RObcjqUIfu1kzWiTtCkMr6Tf4gqCl5fnqDdTC/ QUqx9pXRV2ITidQMqdCDmlPIGKf4+NmPqvv0EyKemFVDmei/ced4i+3MGTpQrESppR AhXXil0XZGhNcpJkFKvx1OM04DOLOfOh/SWMWrcw= Date: Wed, 23 Oct 2019 10:39:27 +0530 From: Vinod Koul To: Peng Ma Cc: dan.j.williams@intel.com, leoyang.li@nxp.com, anders.roxell@linaro.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [next, v2] dmaengine: fsl-dpaa2-qdma: export the symbols Message-ID: <20191023050927.GP2654@vkoul-mobl> References: <20191023045617.22764-1-peng.ma@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023045617.22764-1-peng.ma@nxp.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 23-10-19, 12:56, Peng Ma wrote: > The symbols were not exported leading to error: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/dma/fsl-dpaa2-qdma/dpdmai.o > see include/linux/module.h for more information > GZIP arch/arm64/boot/Image.gz > ERROR: "dpdmai_enable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_set_rx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_get_tx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_get_rx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_get_attributes" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_open" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_close" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_disable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_reset" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL > make[2]: *** [__modpost] Error 1 > make[1]: *** [modules] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [sub-make] Error 2 > > So export it. Applied, thanks -- ~Vinod