dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove
@ 2019-11-04 16:16 Chuhong Yuan
  2019-11-05  9:01 ` Paul Cercueil
  2019-11-08  3:54 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-04 16:16 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: Paul Cercueil, Zubair Lutfullah Kakakhel, Dan Williams,
	Vinod Koul, dmaengine, linux-kernel, Chuhong Yuan

The remove misses to disable and unprepare jzdma->clk.
Add a call to clk_disable_unprepare to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
 drivers/dma/dma-jz4780.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
index cafb1cc065bb..66ab76b9520f 100644
--- a/drivers/dma/dma-jz4780.c
+++ b/drivers/dma/dma-jz4780.c
@@ -987,6 +987,7 @@ static int jz4780_dma_remove(struct platform_device *pdev)
 
 	of_dma_controller_free(pdev->dev.of_node);
 
+	clk_disable_unprepare(jzdma->clk);
 	free_irq(jzdma->irq, jzdma);
 
 	for (i = 0; i < jzdma->soc_data->nb_channels; i++)
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove
  2019-11-04 16:16 [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove Chuhong Yuan
@ 2019-11-05  9:01 ` Paul Cercueil
  2019-11-08  3:54 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Paul Cercueil @ 2019-11-05  9:01 UTC (permalink / raw)
  To: Chuhong Yuan
  Cc: Zubair Lutfullah Kakakhel, Dan Williams, Vinod Koul, dmaengine,
	linux-kernel

Hi,


Le mar., nov. 5, 2019 at 00:16, Chuhong Yuan <hslester96@gmail.com> a 
écrit :
> The remove misses to disable and unprepare jzdma->clk.
> Add a call to clk_disable_unprepare to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks.


> ---
>  drivers/dma/dma-jz4780.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index cafb1cc065bb..66ab76b9520f 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -987,6 +987,7 @@ static int jz4780_dma_remove(struct 
> platform_device *pdev)
> 
>  	of_dma_controller_free(pdev->dev.of_node);
> 
> +	clk_disable_unprepare(jzdma->clk);
>  	free_irq(jzdma->irq, jzdma);
> 
>  	for (i = 0; i < jzdma->soc_data->nb_channels; i++)
> --
> 2.23.0
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove
  2019-11-04 16:16 [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove Chuhong Yuan
  2019-11-05  9:01 ` Paul Cercueil
@ 2019-11-08  3:54 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-11-08  3:54 UTC (permalink / raw)
  To: Chuhong Yuan
  Cc: Paul Cercueil, Zubair Lutfullah Kakakhel, Dan Williams,
	dmaengine, linux-kernel

On 05-11-19, 00:16, Chuhong Yuan wrote:
> The remove misses to disable and unprepare jzdma->clk.
> Add a call to clk_disable_unprepare to fix it.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 16:16 [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove Chuhong Yuan
2019-11-05  9:01 ` Paul Cercueil
2019-11-08  3:54 ` Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git