dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] dma/zx/remove: Removed dmam_pool_destroy from remove method
@ 2019-10-24  4:16 Satendra Singh Thakur
  2019-11-05 16:58 ` Vinod Koul
  0 siblings, 1 reply; 3+ messages in thread
From: Satendra Singh Thakur @ 2019-10-24  4:16 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: Satendra Singh Thakur, Jun Nie, Shawn Guo, Vinod Koul,
	Dan Williams, linux-arm-kernel, dmaengine, linux-kernel

In the probe method dmam_pool_create is used. Therefore, there is no
need to explicitly call dmam_pool_destroy in remove method as this
will be automatically taken care by devres

Signed-off-by: Satendra Singh Thakur <sst2005@gmail.com>
---
 drivers/dma/zx_dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c
index 9f4436f7c914..7e4e457ac6d5 100644
--- a/drivers/dma/zx_dma.c
+++ b/drivers/dma/zx_dma.c
@@ -894,7 +894,6 @@ static int zx_dma_remove(struct platform_device *op)
 		list_del(&c->vc.chan.device_node);
 	}
 	clk_disable_unprepare(d->clk);
-	dmam_pool_destroy(d->pool);
 
 	return 0;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dma/zx/remove: Removed dmam_pool_destroy from remove method
  2019-10-24  4:16 [PATCH] dma/zx/remove: Removed dmam_pool_destroy from remove method Satendra Singh Thakur
@ 2019-11-05 16:58 ` Vinod Koul
  2019-11-09 11:36   ` [PATCH v1] dmaengine: zx: remove: removed dmam_pool_destroy Satendra Singh Thakur
  0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2019-11-05 16:58 UTC (permalink / raw)
  To: Satendra Singh Thakur
  Cc: Jun Nie, Shawn Guo, Dan Williams, linux-arm-kernel, dmaengine,
	linux-kernel

On 24-10-19, 09:46, Satendra Singh Thakur wrote:
> In the probe method dmam_pool_create is used. Therefore, there is no
> need to explicitly call dmam_pool_destroy in remove method as this
> will be automatically taken care by devres

Please do not reinvent system tags, git log is your friend to check for
the tags to be used.

In this case, it is dmaengine: zx: remove ...


> 
> Signed-off-by: Satendra Singh Thakur <sst2005@gmail.com>
> ---
>  drivers/dma/zx_dma.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c
> index 9f4436f7c914..7e4e457ac6d5 100644
> --- a/drivers/dma/zx_dma.c
> +++ b/drivers/dma/zx_dma.c
> @@ -894,7 +894,6 @@ static int zx_dma_remove(struct platform_device *op)
>  		list_del(&c->vc.chan.device_node);
>  	}
>  	clk_disable_unprepare(d->clk);
> -	dmam_pool_destroy(d->pool);
>  
>  	return 0;
>  }
> -- 
> 2.17.1

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v1] dmaengine: zx: remove: removed dmam_pool_destroy
  2019-11-05 16:58 ` Vinod Koul
@ 2019-11-09 11:36   ` Satendra Singh Thakur
  0 siblings, 0 replies; 3+ messages in thread
From: Satendra Singh Thakur @ 2019-11-09 11:36 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: Satendra Singh Thakur, Jun Nie, Shawn Guo, Vinod Koul,
	Dan Williams, linux-arm-kernel, dmaengine, linux-kernel

In the probe method dmam_pool_create is used. Therefore, there is no
need to explicitly call dmam_pool_destroy in remove method as this
will be automatically taken care by devres

Signed-off-by: Satendra Singh Thakur <sst2005@gmail.com>
---
 v1: modified the subject line with new tags

 drivers/dma/zx_dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c
index 9f4436f7c914..7e4e457ac6d5 100644
--- a/drivers/dma/zx_dma.c
+++ b/drivers/dma/zx_dma.c
@@ -894,7 +894,6 @@ static int zx_dma_remove(struct platform_device *op)
 		list_del(&c->vc.chan.device_node);
 	}
 	clk_disable_unprepare(d->clk);
-	dmam_pool_destroy(d->pool);
 
 	return 0;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24  4:16 [PATCH] dma/zx/remove: Removed dmam_pool_destroy from remove method Satendra Singh Thakur
2019-11-05 16:58 ` Vinod Koul
2019-11-09 11:36   ` [PATCH v1] dmaengine: zx: remove: removed dmam_pool_destroy Satendra Singh Thakur

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git