From: Sascha Hauer <s.hauer@pengutronix.de>
To: dmaengine@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH 0/5] virt-dma and i.MX SDMA fixes
Date: Fri, 6 Dec 2019 14:53:39 +0100 [thread overview]
Message-ID: <20191206135344.29330-1-s.hauer@pengutronix.de> (raw)
The i.MX SDMA driver leaks memory when a currently running descriptor is
aborted. Calling vchan_terminate_vdesc() on it to fix this revealed that
the virt-dma support calls the desc_free with the spin_lock held. This
doesn't work for the SDMA driver because it calls dma_free_coherent in
its desc_free hook. This series aims to fix that up.
Sascha
Sascha Hauer (5):
dmaengine: virt-dma: Add missing locking around list operations
dmaengine: virt-dma: Do not call desc_free() under a spin_lock
dmaengine: imx-sdma: rename function
dmaengine: imx-sdma: find desc first in sdma_tx_status
dmaengine: imx-sdma: Fix memory leak
drivers/dma/imx-sdma.c | 37 ++++++++++++++++++++++---------------
drivers/dma/virt-dma.c | 1 +
drivers/dma/virt-dma.h | 26 ++++++++++----------------
3 files changed, 33 insertions(+), 31 deletions(-)
--
2.24.0
next reply other threads:[~2019-12-06 13:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 13:53 Sascha Hauer [this message]
2019-12-06 13:53 ` [PATCH 1/5] dmaengine: virt-dma: Add missing locking around list operations Sascha Hauer
2019-12-09 7:38 ` Peter Ujfalusi
2019-12-10 11:56 ` Sascha Hauer
2019-12-06 13:53 ` [PATCH 2/5] dmaengine: virt-dma: Do not call desc_free() under a spin_lock Sascha Hauer
2019-12-09 7:48 ` Peter Ujfalusi
2019-12-09 8:33 ` Peter Ujfalusi
2019-12-10 11:58 ` Sascha Hauer
2019-12-06 13:53 ` [PATCH 3/5] dmaengine: imx-sdma: rename function Sascha Hauer
2019-12-06 13:53 ` [PATCH 4/5] dmaengine: imx-sdma: find desc first in sdma_tx_status Sascha Hauer
2019-12-06 13:53 ` [PATCH 5/5] dmaengine: imx-sdma: Fix memory leak Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206135344.29330-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=peter.ujfalusi@ti.com \
--cc=robert.jarzmik@free.fr \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).