From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDBEC43603 for ; Tue, 10 Dec 2019 11:56:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C176120726 for ; Tue, 10 Dec 2019 11:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727317AbfLJL4k (ORCPT ); Tue, 10 Dec 2019 06:56:40 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:52439 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726956AbfLJL4k (ORCPT ); Tue, 10 Dec 2019 06:56:40 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iee86-00013F-CK; Tue, 10 Dec 2019 12:56:38 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iee85-00089r-C9; Tue, 10 Dec 2019 12:56:37 +0100 Date: Tue, 10 Dec 2019 12:56:37 +0100 From: Sascha Hauer To: Peter Ujfalusi Cc: dmaengine@vger.kernel.org, Vinod Koul , Robert Jarzmik , NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH 1/5] dmaengine: virt-dma: Add missing locking around list operations Message-ID: <20191210115637.kpoxhnumzqwd6e4f@pengutronix.de> References: <20191206135344.29330-1-s.hauer@pengutronix.de> <20191206135344.29330-2-s.hauer@pengutronix.de> <2da64628-20e5-b12d-798e-b47cf025badc@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2da64628-20e5-b12d-798e-b47cf025badc@ti.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:56:21 up 155 days, 18:06, 143 users, load average: 0.17, 0.15, 0.16 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Mon, Dec 09, 2019 at 09:38:17AM +0200, Peter Ujfalusi wrote: > Hi Sascha, > > On 06/12/2019 15.53, Sascha Hauer wrote: > > All list operations are protected by &vc->lock. As vchan_vdesc_fini() > > is called unlocked add the missing locking around the list operations. > > At this commit the vhcan_vdesc_fini() _is_ called when the lock is held > via vchan_terminate_vdesc() which must be called with the lock held... > > Swap patch 1 and 2. Right, will do. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |