From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B10B6C33CAF for ; Thu, 16 Jan 2020 17:23:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 859A52468C for ; Thu, 16 Jan 2020 17:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195394; bh=C9LryPPI8PsxaJh91bW40PmXS34SlvRrDvM0ud5fJqA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fH3E4iFs8RSjLWGZEWlzWEzMjRBhjbZA4/3JGDmJufqXggCFWj2GqpThOlYZQM6wC P4ChzcucwpJ+6XMszozOnzJ/3zpYYazr9UpkkbsrCE6+92lDJOFsQ861KczbhTj8PT jFeccJWIGru60s3ZYtOGVizx0CQA3aU+4w9qjR3E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390098AbgAPRXL (ORCPT ); Thu, 16 Jan 2020 12:23:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:57930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390699AbgAPRNR (ORCPT ); Thu, 16 Jan 2020 12:13:17 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 243432469F; Thu, 16 Jan 2020 17:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194797; bh=C9LryPPI8PsxaJh91bW40PmXS34SlvRrDvM0ud5fJqA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=stMVjiCookmKK7J0kL2gEXUDZAL2nqDSpnO1FawTwNJ4sYVPLg632CiwqFTwLP+ue m1W46oPO4mFdWNPIZ2xd/PkiMbuvkW6q2PFjsnd4BsbFA9R6cqmQttq7/khJSwz6Zd QrA6rMGQmSCjgb+p3jM6X6d7V2d5+jnGH30vq4oo= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Alexander.Barabash@dell.com" , Alexander Barabash , Dave Jiang , Vinod Koul , Sasha Levin , dmaengine@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 609/671] ioat: ioat_alloc_ring() failure handling. Date: Thu, 16 Jan 2020 12:04:07 -0500 Message-Id: <20200116170509.12787-346-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116170509.12787-1-sashal@kernel.org> References: <20200116170509.12787-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org From: "Alexander.Barabash@dell.com" [ Upstream commit b0b5ce1010ffc50015eaec72b0028aaae3f526bb ] If dma_alloc_coherent() returns NULL in ioat_alloc_ring(), ring allocation must not proceed. Until now, if the first call to dma_alloc_coherent() in ioat_alloc_ring() returned NULL, the processing could proceed, failing with NULL-pointer dereferencing further down the line. Signed-off-by: Alexander Barabash Acked-by: Dave Jiang Link: https://lore.kernel.org/r/75e9c0e84c3345d693c606c64f8b9ab5@x13pwhopdag1307.AMER.DELL.COM Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/ioat/dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c index 23fb2fa04000..b94cece58b98 100644 --- a/drivers/dma/ioat/dma.c +++ b/drivers/dma/ioat/dma.c @@ -388,10 +388,11 @@ ioat_alloc_ring(struct dma_chan *c, int order, gfp_t flags) descs->virt = dma_alloc_coherent(to_dev(ioat_chan), SZ_2M, &descs->hw, flags); - if (!descs->virt && (i > 0)) { + if (!descs->virt) { int idx; for (idx = 0; idx < i; idx++) { + descs = &ioat_chan->descs[idx]; dma_free_coherent(to_dev(ioat_chan), SZ_2M, descs->virt, descs->hw); descs->virt = NULL; -- 2.20.1