From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE9AC3524D for ; Mon, 3 Feb 2020 08:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10E3920721 for ; Mon, 3 Feb 2020 08:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727352AbgBCIY6 (ORCPT ); Mon, 3 Feb 2020 03:24:58 -0500 Received: from esa6.microchip.iphmx.com ([216.71.154.253]:62548 "EHLO esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726369AbgBCIY6 (ORCPT ); Mon, 3 Feb 2020 03:24:58 -0500 Received-SPF: Pass (esa6.microchip.iphmx.com: domain of Ludovic.Desroches@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Ludovic.Desroches@microchip.com"; x-sender="Ludovic.Desroches@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa6.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Ludovic.Desroches@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa6.microchip.iphmx.com; dkim=none (message not signed) header.i=none; spf=Pass smtp.mailfrom=Ludovic.Desroches@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: LYzB8tjFzwME2IoR4inF3aAMR7E8mFznysBZRpxY0qLtLp+o30w47celA5tYohtq/EQ+OPcUPP VOwpY9HfKlqC6+tVpHI/0SfinRC93oEXfSydvmuHNe1VOWKjHXeBWewDHhMugGaj0KAVL8QVZC efDneFt+/tM/CAlk2ufRy0ph/PFrbDy3SBhRQ66vTGKKjID6cPvp8N2dyl/IR+x/Sugp0GYHLi c4ZbyGl077x69yTYNOvkVLpov63QtXs9Ys2s2bHUKvCeOxL6pbTNG9+S4qIYotYLhAQkb3zr4j oIo= X-IronPort-AV: E=Sophos;i="5.70,397,1574146800"; d="scan'208";a="1018402" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Feb 2020 01:24:57 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 3 Feb 2020 01:24:57 -0700 Received: from localhost (10.10.85.251) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Mon, 3 Feb 2020 01:24:56 -0700 Date: Mon, 3 Feb 2020 09:24:27 +0100 From: Ludovic Desroches To: Tudor Ambarus - M18064 CC: "dan.j.williams@intel.com" , "vkoul@kernel.org" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 01/10] dmaengine: at_hdmac: Substitute kzalloc with kmalloc Message-ID: <20200203082427.bog6ykmxvixeisg5@M43218.corp.atmel.com> Mail-Followup-To: Tudor Ambarus - M18064 , "dan.j.williams@intel.com" , "vkoul@kernel.org" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20200123140237.125799-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200123140237.125799-1-tudor.ambarus@microchip.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Thu, Jan 23, 2020 at 02:03:02PM +0000, Tudor Ambarus - M18064 wrote: > From: Tudor Ambarus > > All members of the structure are initialized below in the function, > there is no need to use kzalloc. > > Signed-off-by: Tudor Ambarus Hi Tudor, It sounds good for me. Thanks for the cleanup and deadlock fixes. For the whole set of patches: Acked-by: Ludovic Desroches Ludovic > --- > drivers/dma/at_hdmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index 672c73b4a2d4..cad6dcd9cfb5 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -1671,7 +1671,7 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec, > dma_cap_zero(mask); > dma_cap_set(DMA_SLAVE, mask); > > - atslave = kzalloc(sizeof(*atslave), GFP_KERNEL); > + atslave = kmalloc(sizeof(*atslave), GFP_KERNEL); > if (!atslave) > return NULL; > > -- > 2.23.0