From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: remove set but unused 'rc'
Date: Fri, 28 Feb 2020 11:49:34 +0530 [thread overview]
Message-ID: <20200228061934.GA4148@vkoul-mobl> (raw)
In-Reply-To: <701657fb-bba5-2733-05ef-fa181d562223@intel.com>
On 25-02-20, 09:14, Dave Jiang wrote:
>
>
> On 2/25/20 1:14 AM, Vinod Koul wrote:
> > The driver assigns result of check_vma() to rc and never checks the
> > result, so remove the assignment
> >
> > drivers/dma/idxd/cdev.c: In function ‘idxd_cdev_mmap’:
> > drivers/dma/idxd/cdev.c:136:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
> > 136 | int rc;
> > | ^~
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >
> > Dave, if you want the result of the check_vma() to be checked, feel free to
> > send the patch for that
>
> Yes I will send a fix. Mistake from several code merges. Oops.
Ok, no issues
--
~Vinod
prev parent reply other threads:[~2020-02-28 6:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 8:14 [PATCH] dmaengine: idxd: remove set but unused 'rc' Vinod Koul
2020-02-25 16:14 ` Dave Jiang
2020-02-28 6:19 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228061934.GA4148@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).