dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] dmaengine: fsl-dpaa2-qdma: remove set but not used variable 'dpaa2_qdma'
@ 2020-03-03 13:13 YueHaibing
  2020-03-06 13:35 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-03-03 13:13 UTC (permalink / raw)
  To: vkoul, dan.j.williams, peng.ma, yuehaibing; +Cc: dmaengine, linux-kernel

drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c: In function dpaa2_qdma_shutdown:
drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c:795:28: warning: variable dpaa2_qdma set but not used [-Wunused-but-set-variable]

commit 3e0ca3c38dc2 ("dmaengine: fsl-dpaa2-qdma: Adding shutdown hook")
involved this, remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c b/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c
index fabbbb9..4ec909e 100644
--- a/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c
+++ b/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c
@@ -792,13 +792,11 @@ static int dpaa2_qdma_remove(struct fsl_mc_device *ls_dev)
 
 static void dpaa2_qdma_shutdown(struct fsl_mc_device *ls_dev)
 {
-	struct dpaa2_qdma_engine *dpaa2_qdma;
 	struct dpaa2_qdma_priv *priv;
 	struct device *dev;
 
 	dev = &ls_dev->dev;
 	priv = dev_get_drvdata(dev);
-	dpaa2_qdma = priv->dpaa2_qdma;
 
 	dpdmai_disable(priv->mc_io, 0, ls_dev->mc_handle);
 	dpaa2_dpdmai_dpio_unbind(priv);
-- 
2.7.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] dmaengine: fsl-dpaa2-qdma: remove set but not used variable 'dpaa2_qdma'
  2020-03-03 13:13 [PATCH -next] dmaengine: fsl-dpaa2-qdma: remove set but not used variable 'dpaa2_qdma' YueHaibing
@ 2020-03-06 13:35 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-03-06 13:35 UTC (permalink / raw)
  To: YueHaibing; +Cc: dan.j.williams, peng.ma, dmaengine, linux-kernel

On 03-03-20, 21:13, YueHaibing wrote:
> drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c: In function dpaa2_qdma_shutdown:
> drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c:795:28: warning: variable dpaa2_qdma set but not used [-Wunused-but-set-variable]
> 
> commit 3e0ca3c38dc2 ("dmaengine: fsl-dpaa2-qdma: Adding shutdown hook")
> involved this, remove it.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03 13:13 [PATCH -next] dmaengine: fsl-dpaa2-qdma: remove set but not used variable 'dpaa2_qdma' YueHaibing
2020-03-06 13:35 ` Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git