* [PATCH 2/5] dt-bindings: dma: dw: Add max burst transaction length property bindings
[not found] <20200306131035.10937-1-Sergey.Semin@baikalelectronics.ru>
@ 2020-03-06 13:10 ` Sergey.Semin
2020-03-12 21:33 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Sergey.Semin @ 2020-03-06 13:10 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Mark Rutland
Cc: Serge Semin, Serge Semin, Alexey Malahov, Thomas Bogendoerfer,
Paul Burton, Ralf Baechle, dmaengine, devicetree, linux-kernel
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
This array property is used to indicate the maximum burst transaction
length supported by each DMA channel.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
.../devicetree/bindings/dma/snps,dma-spear1340.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
index d7f9383ceb8f..308ec6482064 100644
--- a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
+++ b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
@@ -126,6 +126,18 @@ properties:
enum: [0, 1]
default: 0
+ snps,max-burst-len:
+ description: |
+ Maximum length of burst transactions supported by hardware.
+ It's an array property with one cell per channel in units of
+ CTLx register SRC_TR_WIDTH/DST_TR_WIDTH field.
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32-array
+ - maxItems: 8
+ items:
+ enum: [4, 8, 16, 32, 64, 128, 256]
+ default: 0
+
snps,dma-protection-control:
description: |
Bits one-to-one passed to the AHB HPROT[3:1] bus. Each bit setting
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] dt-bindings: dma: dw: Add max burst transaction length property bindings
2020-03-06 13:10 ` [PATCH 2/5] dt-bindings: dma: dw: Add max burst transaction length property bindings Sergey.Semin
@ 2020-03-12 21:33 ` Rob Herring
2020-04-11 18:21 ` Sergey Semin
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-03-12 21:33 UTC (permalink / raw)
To: Sergey.Semin
Cc: Vinod Koul, Mark Rutland, Serge Semin, Alexey Malahov,
Thomas Bogendoerfer, Paul Burton, Ralf Baechle, dmaengine,
devicetree, linux-kernel
On Fri, Mar 06, 2020 at 04:10:31PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> This array property is used to indicate the maximum burst transaction
> length supported by each DMA channel.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Burton <paulburton@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
> .../devicetree/bindings/dma/snps,dma-spear1340.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
> index d7f9383ceb8f..308ec6482064 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
> @@ -126,6 +126,18 @@ properties:
> enum: [0, 1]
> default: 0
>
> + snps,max-burst-len:
> + description: |
> + Maximum length of burst transactions supported by hardware.
> + It's an array property with one cell per channel in units of
> + CTLx register SRC_TR_WIDTH/DST_TR_WIDTH field.
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32-array
> + - maxItems: 8
> + items:
> + enum: [4, 8, 16, 32, 64, 128, 256]
> + default: 0
The default needs to be an allowed value in the enum.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] dt-bindings: dma: dw: Add max burst transaction length property bindings
2020-03-12 21:33 ` Rob Herring
@ 2020-04-11 18:21 ` Sergey Semin
0 siblings, 0 replies; 3+ messages in thread
From: Sergey Semin @ 2020-04-11 18:21 UTC (permalink / raw)
To: Rob Herring
Cc: Vinod Koul, Mark Rutland, Alexey Malahov, Thomas Bogendoerfer,
Paul Burton, Ralf Baechle, dmaengine, devicetree, linux-kernel
On Thu, Mar 12, 2020 at 04:33:30PM -0500, Rob Herring wrote:
> On Fri, Mar 06, 2020 at 04:10:31PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> > From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> >
> > This array property is used to indicate the maximum burst transaction
> > length supported by each DMA channel.
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Paul Burton <paulburton@kernel.org>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > ---
> > .../devicetree/bindings/dma/snps,dma-spear1340.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
> > index d7f9383ceb8f..308ec6482064 100644
> > --- a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
> > +++ b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
> > @@ -126,6 +126,18 @@ properties:
> > enum: [0, 1]
> > default: 0
> >
> > + snps,max-burst-len:
> > + description: |
> > + Maximum length of burst transactions supported by hardware.
> > + It's an array property with one cell per channel in units of
> > + CTLx register SRC_TR_WIDTH/DST_TR_WIDTH field.
> > + allOf:
> > + - $ref: /schemas/types.yaml#/definitions/uint32-array
> > + - maxItems: 8
> > + items:
> > + enum: [4, 8, 16, 32, 64, 128, 256]
> > + default: 0
>
> The default needs to be an allowed value in the enum.
Right. I'll fix it.
-Sergey
>
> Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-11 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200306131035.10937-1-Sergey.Semin@baikalelectronics.ru>
2020-03-06 13:10 ` [PATCH 2/5] dt-bindings: dma: dw: Add max burst transaction length property bindings Sergey.Semin
2020-03-12 21:33 ` Rob Herring
2020-04-11 18:21 ` Sergey Semin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).