* [PATCH] dmaengine: uniphier-xdmac: Remove redandant error log for platform_get_irq
@ 2020-03-23 17:19 Vinod Koul
2020-03-26 6:54 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2020-03-23 17:19 UTC (permalink / raw)
To: dmaengine; +Cc: Vinod Koul, Masahiro Yamada, kbuild test robot
platform_get_irq prints the error on failure, so there is no need to
have caller add a log.
Remove the log in uniphier_xdmac_probe() for platform_get_irq() failure
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/uniphier-xdmac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dma/uniphier-xdmac.c b/drivers/dma/uniphier-xdmac.c
index 2f6fd518d180..7b2f8a8c2d31 100644
--- a/drivers/dma/uniphier-xdmac.c
+++ b/drivers/dma/uniphier-xdmac.c
@@ -525,10 +525,8 @@ static int uniphier_xdmac_probe(struct platform_device *pdev)
uniphier_xdmac_chan_init(xdev, i);
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "Failed to get IRQ\n");
+ if (irq < 0)
return irq;
- }
ret = devm_request_irq(dev, irq, uniphier_xdmac_irq_handler,
IRQF_SHARED, "xdmac", xdev);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-26 6:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 17:19 [PATCH] dmaengine: uniphier-xdmac: Remove redandant error log for platform_get_irq Vinod Koul
2020-03-26 6:54 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).