From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 829B7C2BB55 for ; Sat, 11 Apr 2020 18:21:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4469420B1F for ; Sat, 11 Apr 2020 18:21:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbgDKSV3 (ORCPT ); Sat, 11 Apr 2020 14:21:29 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:43370 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbgDKSV2 (ORCPT ); Sat, 11 Apr 2020 14:21:28 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id D8BA18030786; Sat, 11 Apr 2020 18:21:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jxLEWrmPJugI; Sat, 11 Apr 2020 21:21:26 +0300 (MSK) Date: Sat, 11 Apr 2020 21:21:59 +0300 From: Sergey Semin To: Rob Herring CC: Vinod Koul , Mark Rutland , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , , , Subject: Re: [PATCH 2/5] dt-bindings: dma: dw: Add max burst transaction length property bindings Message-ID: <20200411182159.fjjazqn6jjl3icep@ubsrv2.baikal.int> References: <20200306131035.10937-1-Sergey.Semin@baikalelectronics.ru> <20200306131049.37EDD8030708@mail.baikalelectronics.ru> <20200312213330.GA30463@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200312213330.GA30463@bogus> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Thu, Mar 12, 2020 at 04:33:30PM -0500, Rob Herring wrote: > On Fri, Mar 06, 2020 at 04:10:31PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > > From: Serge Semin > > > > This array property is used to indicate the maximum burst transaction > > length supported by each DMA channel. > > > > Signed-off-by: Serge Semin > > Signed-off-by: Alexey Malahov > > Cc: Thomas Bogendoerfer > > Cc: Paul Burton > > Cc: Ralf Baechle > > --- > > .../devicetree/bindings/dma/snps,dma-spear1340.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml > > index d7f9383ceb8f..308ec6482064 100644 > > --- a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml > > +++ b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml > > @@ -126,6 +126,18 @@ properties: > > enum: [0, 1] > > default: 0 > > > > + snps,max-burst-len: > > + description: | > > + Maximum length of burst transactions supported by hardware. > > + It's an array property with one cell per channel in units of > > + CTLx register SRC_TR_WIDTH/DST_TR_WIDTH field. > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32-array > > + - maxItems: 8 > > + items: > > + enum: [4, 8, 16, 32, 64, 128, 256] > > + default: 0 > > The default needs to be an allowed value in the enum. Right. I'll fix it. -Sergey > > Rob