From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dave Jiang <dave.jiang@intel.com>
Cc: vkoul@kernel.org, megha.dey@linux.intel.com, maz@kernel.org,
bhelgaas@google.com, rafael@kernel.org,
gregkh@linuxfoundation.org, tglx@linutronix.de, hpa@zytor.com,
alex.williamson@redhat.com, jacob.jun.pan@intel.com,
ashok.raj@intel.com, yi.l.liu@intel.com, baolu.lu@intel.com,
kevin.tian@intel.com, sanjay.k.kumar@intel.com,
tony.luck@intel.com, jing.lin@intel.com,
dan.j.williams@intel.com, kwankhede@nvidia.com,
eric.auger@redhat.com, parav@mellanox.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH RFC 07/15] Documentation: Interrupt Message store
Date: Thu, 23 Apr 2020 17:04:36 -0300 [thread overview]
Message-ID: <20200423200436.GA29181@ziepe.ca> (raw)
In-Reply-To: <158751207000.36773.18208950543781892.stgit@djiang5-desk3.ch.intel.com>
On Tue, Apr 21, 2020 at 04:34:30PM -0700, Dave Jiang wrote:
> diff --git a/Documentation/ims-howto.rst b/Documentation/ims-howto.rst
> new file mode 100644
> index 000000000000..a18de152b393
> +++ b/Documentation/ims-howto.rst
> @@ -0,0 +1,210 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +.. include:: <isonum.txt>
> +
> +==========================
> +The IMS Driver Guide HOWTO
> +==========================
> +
> +:Authors: Megha Dey
> +
> +:Copyright: 2020 Intel Corporation
> +
> +About this guide
> +================
> +
> +This guide describes the basics of Interrupt Message Store (IMS), the
> +need to introduce a new interrupt mechanism, implementation details of
> +IMS in the kernel, driver changes required to support IMS and the general
> +misconceptions and FAQs associated with IMS.
I'm not sure why we need to call this IMS in kernel documentat? I know
Intel is using this term, but this document is really only talking
about extending the existing platform_msi stuff, which looks pretty
good actually.
A lot of this is good for the cover letter..
> +Implementation of IMS in the kernel
> +===================================
> +
> +The Linux kernel today already provides a generic mechanism to support
> +non-PCI compliant MSI interrupts for platform devices (platform-msi.c).
> +To support IMS interrupts, we create a new IMS IRQ domain and extend the
> +existing infrastructure. Dynamic allocation of IMS vectors is a requirement
> +for devices which support Scalable I/O Virtualization. A driver can allocate
> +and free vectors not just once during probe (as was the case with MSI/MSI-X)
> +but also in the post probe phase where actual demand is available. Thus, a
> +new API, platform_msi_domain_alloc_irqs_group is introduced which drivers
> +using IMS would be able to call multiple times. The vectors allocated each
> +time this API is called are associated with a group ID. To free the vectors
> +associated with a particular group, the platform_msi_domain_free_irqs_group
> +API can be called. The existing drivers using platform-msi infrastructure
> +will continue to use the existing alloc (platform_msi_domain_alloc_irqs)
> +and free (platform_msi_domain_free_irqs) APIs and are assigned a default
> +group ID of 0.
> +
> +Thus, platform-msi.c provides the generic methods which can be used by any
> +non-pci MSI interrupt type while the newly created ims-msi.c provides IMS
> +specific callbacks that can be used by drivers capable of generating IMS
> +interrupts.
How exactly is an IMS interrupt is different from a platform msi?
It looks like it is just some thin wrapper around msi_domain - what is
it for?
> +FAQs and general misconceptions:
> +================================
> +
> +** There were some concerns raised by Thomas Gleixner and Marc Zyngier
> +during Linux plumbers conference 2019:
> +
> +1. Enumeration of IMS needs to be done by PCI core code and not by
> + individual device drivers:
> +
> + Currently, if the kernel needs a generic way to discover IMS capability
> + without host driver dependency, the PCIE Designated Vendor specific
> +
> + However, we cannot have a standard way of enumerating the IMS size
> + because for context based devices, the interrupt message is part of
> + the context itself which is managed entirely by the driver. Since
> + context creation is done on demand, there is no way to tell during boot
> + time, the maximum number of contexts (and hence the number of interrupt
> + messages)that the device can support.
FWIW, I agree with this.
Like platform-msi, IMS should be controlled entirely by the driver.
> +2. Why is Intel designing a new interrupt mechanism rather than extending
> + MSI-X to address its limitations? Isn't 2048 device interrupts enough?
> +
> + MSI-X has a rigid definition of one-table and on-device storage and does
> + not provide the full flexibility required for future multi-tile
> + accelerator designs.
> + IMS was envisioned to be used with large number of ADIs in devices where
> + each will need unique interrupt resources. For example, a DSA shared
> + work queue can support large number of clients where each client can
> + have its own interrupt. In future, with user interrupts, we expect the
> + demand for messages to increase further.
Generally agree
> +Device Driver Changes:
> +=====================
> +
> +1. platform_msi_domain_alloc_irqs_group (struct device *dev, unsigned int
> + nvec, const struct platform_msi_ops *platform_ops, int *group_id)
> + to allocate IMS interrupts, where:
> +
> + dev: The device for which to allocate interrupts
> + nvec: The number of interrupts to allocate
> + platform_ops: Callbacks for platform MSI ops (to be provided by driver)
> + group_id: returned by the call, to be used to free IRQs of a certain type
> +
> + eg: static struct platform_msi_ops ims_ops = {
> + .irq_mask = ims_irq_mask,
> + .irq_unmask = ims_irq_unmask,
> + .write_msg = ims_write_msg,
> + };
> +
> + int group;
> + platform_msi_domain_alloc_irqs_group (dev, nvec, platform_ops, &group)
> +
> + where, struct platform_msi_ops:
> + irq_mask: mask an interrupt source
> + irq_unmask: unmask an interrupt source
> + irq_write_msi_msg: write message content
> +
> + This API can be called multiple times. Every time a new group will be
> + associated with the allocated vectors. Group ID starts from 0.
Need much more closer look, but this seems conceptually fine to me.
As above the API here is called platform_msi - which seems good to
me. Again not sure why the word IMS is needed
Jason
next prev parent reply other threads:[~2020-04-23 20:05 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 23:33 [PATCH RFC 00/15] Add VFIO mediated device support and IMS support for the idxd driver Dave Jiang
2020-04-21 23:33 ` [PATCH RFC 01/15] drivers/base: Introduce platform_msi_ops Dave Jiang
2020-04-26 7:01 ` Greg KH
2020-04-27 21:38 ` Dave Jiang
2020-04-28 7:34 ` Greg KH
2020-04-21 23:33 ` [PATCH RFC 02/15] drivers/base: Introduce a new platform-msi list Dave Jiang
2020-04-25 21:13 ` Thomas Gleixner
2020-05-04 0:08 ` Dey, Megha
2020-04-21 23:34 ` [PATCH RFC 03/15] drivers/base: Allocate/free platform-msi interrupts by group Dave Jiang
2020-04-25 21:23 ` Thomas Gleixner
2020-05-04 0:08 ` Dey, Megha
2020-04-21 23:34 ` [PATCH RFC 04/15] drivers/base: Add support for a new IMS irq domain Dave Jiang
2020-04-23 20:11 ` Jason Gunthorpe
2020-05-01 22:30 ` Dey, Megha
2020-05-03 22:25 ` Jason Gunthorpe
2020-05-03 22:40 ` Dey, Megha
2020-05-03 22:46 ` Jason Gunthorpe
2020-05-04 0:25 ` Dey, Megha
2020-05-04 12:14 ` Jason Gunthorpe
2020-05-06 10:27 ` Tian, Kevin
2020-04-25 21:38 ` Thomas Gleixner
2020-05-04 0:11 ` Dey, Megha
2020-04-21 23:34 ` [PATCH RFC 05/15] ims-msi: Add mask/unmask routines Dave Jiang
2020-04-25 21:49 ` Thomas Gleixner
2020-05-04 0:16 ` Dey, Megha
2020-04-21 23:34 ` [PATCH RFC 06/15] ims-msi: Enable IMS interrupts Dave Jiang
2020-04-25 22:13 ` Thomas Gleixner
2020-05-04 0:17 ` Dey, Megha
2020-04-21 23:34 ` [PATCH RFC 07/15] Documentation: Interrupt Message store Dave Jiang
2020-04-23 20:04 ` Jason Gunthorpe [this message]
2020-05-01 22:32 ` Dey, Megha
2020-05-03 22:28 ` Jason Gunthorpe
2020-05-03 22:41 ` Dey, Megha
2020-04-21 23:34 ` [PATCH RFC 08/15] vfio/mdev: Add a member for iommu domain in mdev_device Dave Jiang
2020-04-21 23:34 ` [PATCH RFC 09/15] vfio/type1: Save domain when attach domain to mdev Dave Jiang
2020-04-21 23:34 ` [PATCH RFC 10/15] dmaengine: idxd: add config support for readonly devices Dave Jiang
2020-04-21 23:34 ` [PATCH RFC 11/15] dmaengine: idxd: add IMS support in base driver Dave Jiang
2020-04-21 23:35 ` [PATCH RFC 12/15] dmaengine: idxd: add device support functions in prep for mdev Dave Jiang
2020-04-21 23:35 ` [PATCH RFC 13/15] dmaengine: idxd: add support for VFIO mediated device Dave Jiang
2020-04-21 23:35 ` [PATCH RFC 14/15] dmaengine: idxd: add error notification from host driver to " Dave Jiang
2020-04-21 23:35 ` [PATCH RFC 15/15] dmaengine: idxd: add ABI documentation for mediated device support Dave Jiang
2020-04-21 23:54 ` [PATCH RFC 00/15] Add VFIO mediated device support and IMS support for the idxd driver Jason Gunthorpe
2020-04-22 0:53 ` Tian, Kevin
2020-04-22 11:50 ` Jason Gunthorpe
2020-04-22 21:14 ` Raj, Ashok
2020-04-23 19:12 ` Jason Gunthorpe
2020-04-24 3:27 ` Tian, Kevin
2020-04-24 12:44 ` Jason Gunthorpe
2020-04-24 16:25 ` Tian, Kevin
2020-04-24 18:12 ` Jason Gunthorpe
2020-04-26 5:18 ` Tian, Kevin
2020-04-26 19:13 ` Jason Gunthorpe
2020-04-27 3:43 ` Alex Williamson
2020-04-27 11:58 ` Jason Gunthorpe
2020-04-27 13:19 ` Alex Williamson
2020-04-27 13:22 ` Jason Gunthorpe
2020-04-27 14:18 ` Alex Williamson
2020-04-27 14:25 ` Jason Gunthorpe
2020-04-27 15:41 ` Alex Williamson
2020-04-27 16:16 ` Jason Gunthorpe
2020-04-27 16:25 ` Dave Jiang
2020-04-27 21:56 ` Jason Gunthorpe
2020-04-29 9:42 ` Tian, Kevin
2020-05-08 20:47 ` Raj, Ashok
2020-05-08 23:16 ` Jason Gunthorpe
2020-05-08 23:52 ` Dave Jiang
2020-05-09 0:09 ` Raj, Ashok
2020-05-09 12:21 ` Jason Gunthorpe
2020-05-13 2:29 ` Jason Wang
2020-05-13 8:30 ` Tian, Kevin
2020-05-13 12:40 ` Jason Gunthorpe
2020-04-27 12:13 ` Tian, Kevin
2020-04-27 12:55 ` Jason Gunthorpe
2020-04-22 21:24 ` Dan Williams
2020-04-23 19:17 ` Dan Williams
2020-04-23 19:49 ` Jason Gunthorpe
2020-05-01 22:31 ` Dey, Megha
2020-05-03 22:21 ` Jason Gunthorpe
2020-05-03 22:32 ` Dey, Megha
2020-04-23 19:18 ` Jason Gunthorpe
2020-05-01 22:31 ` Dey, Megha
2020-05-03 22:22 ` Jason Gunthorpe
2020-05-03 22:31 ` Dey, Megha
2020-05-03 22:36 ` Jason Gunthorpe
2020-05-04 0:20 ` Dey, Megha
2020-04-22 23:04 ` Dey, Megha
2020-04-23 19:44 ` Jason Gunthorpe
2020-05-01 22:32 ` Dey, Megha
2020-04-24 6:31 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423200436.GA29181@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@intel.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=jing.lin@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maz@kernel.org \
--cc=megha.dey@linux.intel.com \
--cc=parav@mellanox.com \
--cc=rafael@kernel.org \
--cc=sanjay.k.kumar@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=x86@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).