From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74954C38A24 for ; Thu, 7 May 2020 14:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A91F2083B for ; Thu, 7 May 2020 14:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588861894; bh=21RvU87suyQJ5Bno2TZaPg+6cnc/R8INOsdBybhJ+a4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=C7oXIjxNK7LbWOOCTV3qhw8SlKMUrz+gZtIE64zvxAXcFnbB+H8Kws7xcPXH5ThU1 OPgRDPgAiFN5VeWQOXsYoPys3BRhZrEkezE412Gd7oNX8M9E+c93pfSroU3/2VbsJc NxJktfS5+3bPOQGpjRLWeAg6zrwXyqfyK6nh9w7M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728820AbgEGOaY (ORCPT ); Thu, 7 May 2020 10:30:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:59198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728815AbgEGOaW (ORCPT ); Thu, 7 May 2020 10:30:22 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB3F520936; Thu, 7 May 2020 14:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588861822; bh=21RvU87suyQJ5Bno2TZaPg+6cnc/R8INOsdBybhJ+a4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vRM0RLH3vH3Y5pmm7WpKQt8PkiRTXJJ9X5OyTIeW6xT90bHnsXudMbGxOtT5iF44r a7k4XbnemjG0mL+cXfMKT/nvZh1/q19+vbH+vTVje9eYS8q1+OqhnvJo4zvtpe6GL2 FIxD4IDi11jM/uP9zt9EFf7ZDZZZ5CIurYd2dD14= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Madhuparna Bhowmik , Vinod Koul , Sasha Levin , dmaengine@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 3/9] dmaengine: pch_dma.c: Avoid data race between probe and irq handler Date: Thu, 7 May 2020 10:30:12 -0400 Message-Id: <20200507143018.27195-3-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200507143018.27195-1-sashal@kernel.org> References: <20200507143018.27195-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org From: Madhuparna Bhowmik [ Upstream commit 2e45676a4d33af47259fa186ea039122ce263ba9 ] pd->dma.dev is read in irq handler pd_irq(). However, it is set to pdev->dev after request_irq(). Therefore, set pd->dma.dev to pdev->dev before request_irq() to avoid data race between pch_dma_probe() and pd_irq(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Madhuparna Bhowmik Link: https://lore.kernel.org/r/20200416062335.29223-1-madhuparnabhowmik10@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/pch_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c index 113605f6fe208..32517003e118e 100644 --- a/drivers/dma/pch_dma.c +++ b/drivers/dma/pch_dma.c @@ -877,6 +877,7 @@ static int pch_dma_probe(struct pci_dev *pdev, } pci_set_master(pdev); + pd->dma.dev = &pdev->dev; err = request_irq(pdev->irq, pd_irq, IRQF_SHARED, DRV_NAME, pd); if (err) { @@ -892,7 +893,6 @@ static int pch_dma_probe(struct pci_dev *pdev, goto err_free_irq; } - pd->dma.dev = &pdev->dev; INIT_LIST_HEAD(&pd->dma.channels); -- 2.20.1