From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 147B0C54E4B for ; Mon, 11 May 2020 20:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9F0B20720 for ; Mon, 11 May 2020 20:05:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731389AbgEKUFc (ORCPT ); Mon, 11 May 2020 16:05:32 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:49948 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729572AbgEKUFc (ORCPT ); Mon, 11 May 2020 16:05:32 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 9901C8030807; Mon, 11 May 2020 20:05:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TaAw1Br-ho0e; Mon, 11 May 2020 23:05:29 +0300 (MSK) Date: Mon, 11 May 2020 23:05:28 +0300 From: Serge Semin To: Andy Shevchenko CC: Serge Semin , Vinod Koul , Viresh Kumar , Rob Herring , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Dan Williams , , , , Subject: Re: [PATCH v2 2/6] dt-bindings: dma: dw: Add max burst transaction length property Message-ID: <20200511200528.nfkc2zkh3bvupn7l@mobilestation> References: <20200306131048.ADBE18030797@mail.baikalelectronics.ru> <20200508105304.14065-1-Sergey.Semin@baikalelectronics.ru> <20200508105304.14065-3-Sergey.Semin@baikalelectronics.ru> <20200508111242.GH185537@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200508111242.GH185537@smile.fi.intel.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Fri, May 08, 2020 at 02:12:42PM +0300, Andy Shevchenko wrote: > On Fri, May 08, 2020 at 01:53:00PM +0300, Serge Semin wrote: > > This array property is used to indicate the maximum burst transaction > > length supported by each DMA channel. > > > + snps,max-burst-len: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + description: | > > + Maximum length of burst transactions supported by hardware. > > + It's an array property with one cell per channel in units of > > + CTLx register SRC_TR_WIDTH/DST_TR_WIDTH (data-width) field. > > + items: > > + maxItems: 8 > > + items: > > > + enum: [4, 8, 16, 32, 64, 128, 256] > > Isn't 1 allowed? Burst length of 1 unit is supported, but in accordance with Data Book the MAX burst length is limited to be equal to a value from the set I submitted. So the max value can be either 4, or 8, or 16 and so on. -Sergey > > > + default: 256 > > -- > With Best Regards, > Andy Shevchenko > >