* [PATCH] dmaengine: ti: k3-udma: Use proper return code in alloc_chan_resources
@ 2020-05-12 13:45 Peter Ujfalusi
2020-05-15 5:52 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2020-05-12 13:45 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine, dan.j.williams
In udma_alloc_chan_resources() if the channel is not willing to stop then
the function should return with error code.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/dma/ti/k3-udma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index 0a041747fb21..89d025a5c599 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -1870,6 +1870,7 @@ static int udma_alloc_chan_resources(struct dma_chan *chan)
udma_stop(uc);
if (udma_is_chan_running(uc)) {
dev_err(ud->dev, "chan%d: won't stop!\n", uc->id);
+ ret = -EBUSY;
goto err_res_free;
}
}
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: ti: k3-udma: Use proper return code in alloc_chan_resources
2020-05-12 13:45 [PATCH] dmaengine: ti: k3-udma: Use proper return code in alloc_chan_resources Peter Ujfalusi
@ 2020-05-15 5:52 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-05-15 5:52 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: dmaengine, dan.j.williams
On 12-05-20, 16:45, Peter Ujfalusi wrote:
> In udma_alloc_chan_resources() if the channel is not willing to stop then
> the function should return with error code.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-15 5:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 13:45 [PATCH] dmaengine: ti: k3-udma: Use proper return code in alloc_chan_resources Peter Ujfalusi
2020-05-15 5:52 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).