From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vkoul@kernel.org>
Cc: <dmaengine@vger.kernel.org>, <dan.j.williams@intel.com>
Subject: [PATCH 0/2] dmaengine: ti: k3-udma: Fixes for alloc_chan_resources
Date: Wed, 27 May 2020 10:06:10 +0300 [thread overview]
Message-ID: <20200527070612.636-1-peter.ujfalusi@ti.com> (raw)
Hi,
It turned out that udma_stop() can not be used to stop the channel which was
left enabled during boot (missing cleanup in early boot) since it would initiate
teardown. This is not supported on non configured channels.
Simply reset the running channel instead fixes the issue.
While looking at this issue I have noticed that the cleanup path misses
resources if the error happens early.
Regards,
Peter
---
Peter Ujfalusi (2):
dmaengine: ti: k3-udma: Fix cleanup code for alloc_chan_resources
dmaengine: ti: k3-udma: Fix the running channel handling in
alloc_chan_resources
drivers/dma/ti/k3-udma.c | 33 +++++++++++++++++----------------
1 file changed, 17 insertions(+), 16 deletions(-)
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next reply other threads:[~2020-05-27 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:06 Peter Ujfalusi [this message]
2020-05-27 7:06 ` [PATCH 1/2] dmaengine: ti: k3-udma: Fix cleanup code for alloc_chan_resources Peter Ujfalusi
2020-05-27 7:06 ` [PATCH 2/2] dmaengine: ti: k3-udma: Fix the running channel handling in alloc_chan_resources Peter Ujfalusi
2020-06-16 15:56 ` [PATCH 0/2] dmaengine: ti: k3-udma: Fixes for alloc_chan_resources Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527070612.636-1-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).