From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Vinod Koul <vkoul@kernel.org>, Viresh Kumar <vireshk@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 09/11] dmaengine: dw: Initialize min_burst capability
Date: Fri, 29 May 2020 13:50:09 +0300 [thread overview]
Message-ID: <20200529105009.GH1634618@smile.fi.intel.com> (raw)
In-Reply-To: <20200529104119.qrqoptp5iz5hs56r@mobilestation>
On Fri, May 29, 2020 at 01:41:19PM +0300, Serge Semin wrote:
> On Fri, May 29, 2020 at 01:29:02PM +0300, Andy Shevchenko wrote:
> > On Fri, May 29, 2020 at 01:25:15PM +0300, Andy Shevchenko wrote:
> > > On Fri, May 29, 2020 at 01:23:59AM +0300, Serge Semin wrote:
...
> > > > /* DMA capabilities */
> > > > + dw->dma.min_burst = 1;
> > >
> > > Perhaps then relaxed maximum, like
> > >
> > > dw->dma.max_burst = 256;
> > >
> > > (channels will update this)
> > >
> > > ?
>
> > And forgot to mention that perhaps we need a definitions for both.
>
> By "definitions for both" do you mean a macro with corresponding parameter
> definition like it's done for the max burst length in the next patch?
> Something like this:
> --- include/linux/platform_data/dma-dw.h
> +++ include/linux/platform_data/dma-dw.h
> +#define DW_DMA_MIN_BURST 1
> +#define DW_DMA_MAX_BURST 256
>
> ?
Yes!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-29 10:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 22:23 [PATCH v4 00/11] dmaengine: dw: Take Baikal-T1 SoC DW DMAC peculiarities into account Serge Semin
2020-05-28 22:23 ` [PATCH v4 01/11] dt-bindings: dma: dw: Convert DW DMAC to DT binding Serge Semin
2020-05-28 22:23 ` [PATCH v4 02/11] dt-bindings: dma: dw: Add max burst transaction length property Serge Semin
2020-05-28 22:23 ` [PATCH v4 03/11] dmaengine: Introduce min burst length capability Serge Semin
2020-05-29 12:07 ` Andy Shevchenko
2020-05-28 22:23 ` [PATCH v4 04/11] dmaengine: Introduce max SG list entries capability Serge Semin
2020-05-28 22:23 ` [PATCH v4 05/11] dmaengine: Introduce DMA-device device_caps callback Serge Semin
2020-05-29 12:12 ` Andy Shevchenko
2020-05-29 14:07 ` Serge Semin
2020-05-28 22:23 ` [PATCH v4 06/11] dmaengine: dw: Take HC_LLP flag into account for noLLP auto-config Serge Semin
2020-05-28 22:23 ` [PATCH v4 07/11] dmaengine: dw: Set DMA device max segment size parameter Serge Semin
2020-05-29 12:18 ` Andy Shevchenko
2020-05-28 22:23 ` [PATCH v4 08/11] dmaengine: dw: Add dummy device_caps callback Serge Semin
2020-05-29 12:19 ` Andy Shevchenko
2020-05-28 22:23 ` [PATCH v4 09/11] dmaengine: dw: Initialize min_burst capability Serge Semin
2020-05-29 10:25 ` Andy Shevchenko
2020-05-29 10:29 ` Andy Shevchenko
2020-05-29 10:41 ` Serge Semin
2020-05-29 10:50 ` Andy Shevchenko [this message]
2020-05-29 10:51 ` Serge Semin
2020-05-28 22:24 ` [PATCH v4 10/11] dmaengine: dw: Introduce max burst length hw config Serge Semin
2020-05-29 10:27 ` Andy Shevchenko
2020-05-28 22:24 ` [PATCH v4 11/11] dmaengine: dw: Initialize max_sg_nents capability Serge Semin
2020-05-29 10:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529105009.GH1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).