From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C7BC433E0 for ; Fri, 29 May 2020 10:50:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23AF52075A for ; Fri, 29 May 2020 10:50:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726509AbgE2KuM (ORCPT ); Fri, 29 May 2020 06:50:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:17708 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbgE2KuK (ORCPT ); Fri, 29 May 2020 06:50:10 -0400 IronPort-SDR: MQpYkXHuBmBRQJVrSORf384O4Bxl8vWiUwbvdJIuDTRN8KBt37wBAjeXJUhYMkcGwlnKLQknUP DzJgrjRbTvxg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2020 03:50:10 -0700 IronPort-SDR: qDeHSxX5EIEVu1yQr2VAMYDeZwnVPe+R7mFXgpk4JTDsMaZP5U99KOOzSNUdGazpWDC/a19Ag4 WZ7sYVmuhScg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,448,1583222400"; d="scan'208";a="256471708" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007.jf.intel.com with ESMTP; 29 May 2020 03:50:06 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jecaX-009bHf-4Z; Fri, 29 May 2020 13:50:09 +0300 Date: Fri, 29 May 2020 13:50:09 +0300 From: Andy Shevchenko To: Serge Semin Cc: Serge Semin , Vinod Koul , Viresh Kumar , Dan Williams , Alexey Malahov , Thomas Bogendoerfer , Arnd Bergmann , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 09/11] dmaengine: dw: Initialize min_burst capability Message-ID: <20200529105009.GH1634618@smile.fi.intel.com> References: <20200528222401.26941-1-Sergey.Semin@baikalelectronics.ru> <20200528222401.26941-10-Sergey.Semin@baikalelectronics.ru> <20200529102515.GD1634618@smile.fi.intel.com> <20200529102902.GG1634618@smile.fi.intel.com> <20200529104119.qrqoptp5iz5hs56r@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200529104119.qrqoptp5iz5hs56r@mobilestation> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Fri, May 29, 2020 at 01:41:19PM +0300, Serge Semin wrote: > On Fri, May 29, 2020 at 01:29:02PM +0300, Andy Shevchenko wrote: > > On Fri, May 29, 2020 at 01:25:15PM +0300, Andy Shevchenko wrote: > > > On Fri, May 29, 2020 at 01:23:59AM +0300, Serge Semin wrote: ... > > > > /* DMA capabilities */ > > > > + dw->dma.min_burst = 1; > > > > > > Perhaps then relaxed maximum, like > > > > > > dw->dma.max_burst = 256; > > > > > > (channels will update this) > > > > > > ? > > > And forgot to mention that perhaps we need a definitions for both. > > By "definitions for both" do you mean a macro with corresponding parameter > definition like it's done for the max burst length in the next patch? > Something like this: > --- include/linux/platform_data/dma-dw.h > +++ include/linux/platform_data/dma-dw.h > +#define DW_DMA_MIN_BURST 1 > +#define DW_DMA_MAX_BURST 256 > > ? Yes! -- With Best Regards, Andy Shevchenko