From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A77C433E0 for ; Wed, 24 Jun 2020 07:29:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24321207DD for ; Wed, 24 Jun 2020 07:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592983756; bh=ytPqR5xyOaqJEvsrk+oYUTZAaRvKKQWw7HgvRa/Nehg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RwqYYif4/VDBv77fO4TObBAwf7XuZQp4QMbk+6UCxuZmKKgnJo+hDDVnq8tpd1S18 hUcKDW4LvWclKodsYFC/r+7vSXDCZoCQ8uDzb9VQlD2RgFrzA1I5ngsHrqkTx9HA8B TiSvCwlpTLUB5zZkuGd6ho1A3+Z4RPmIRSdWvPLQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733114AbgFXH3P (ORCPT ); Wed, 24 Jun 2020 03:29:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:38998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728858AbgFXH3P (ORCPT ); Wed, 24 Jun 2020 03:29:15 -0400 Received: from localhost (unknown [171.61.66.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48C032073E; Wed, 24 Jun 2020 07:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592983755; bh=ytPqR5xyOaqJEvsrk+oYUTZAaRvKKQWw7HgvRa/Nehg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P158rICn+S5i2qpUlvcdNvtDXTp9gZ12fG4TICxRyuSi+RlPQCmwP/j6Np+dFSarc yk7Jc4eASbgAB1U6MX/zIydZSxAwvXtV4cTmxt/yyqOSPp6korgVtSvAWNN6H2aHjP amB5yRogUO8UaztjtK6nOAj1Ga1q63e5ULMY0JNA= Date: Wed, 24 Jun 2020 12:59:11 +0530 From: Vinod Koul To: Dave Jiang Cc: dmaengine@vger.kernel.org, swathi.kovvuri@intel.com Subject: Re: [PATCH] dmaengine: check device and channel list for empty Message-ID: <20200624072911.GL2324254@vkoul-mobl> References: <158957055210.11529.14023177009907426289.stgit@djiang5-desk3.ch.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158957055210.11529.14023177009907426289.stgit@djiang5-desk3.ch.intel.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 15-05-20, 12:22, Dave Jiang wrote: > Check dma device list and channel list for empty before iterate as the > iteration function assume the list to be not empty. With devices and > channels now being hot pluggable this is a condition that needs to be > checked. Otherwise it can cause the iterator to spin forever. Can you rebase and resend, they dont apply on next > > Fixes: e81274cd6b52 ("dmaengine: add support to dynamic register/unregister of channels") Pls drop this empty line > > Reported-by: Swathi Kovvuri > Signed-off-by: Dave Jiang > Tested-by: Swathi Kovvuri -- ~Vinod