From: Vinod Koul <vkoul@kernel.org>
To: Sugar Zhang <sugar.zhang@rock-chips.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dmaengine: pl330: Make sure the debug is idle before doing DMAGO
Date: Wed, 24 Jun 2020 13:11:41 +0530 [thread overview]
Message-ID: <20200624074141.GQ2324254@vkoul-mobl> (raw)
In-Reply-To: <1591234598-78919-1-git-send-email-sugar.zhang@rock-chips.com>
On 04-06-20, 09:36, Sugar Zhang wrote:
> According to the datasheet of pl330:
>
> Example 2-1 Using DMAGO with the debug instruction registers
>
> 1. Create a program for the DMA channel
> 2. Store the program in a region of system memory
> 3. Poll the DBGSTATUS Register to ensure that the debug is idle
> 4. Write to the DBGINST0 Register
> 5. Write to the DBGINST1 Register
> 6. Write zero to the DBGCMD Register
>
> so, we should make sure the debug is idle before step 4/5/6, not
> only step 6. if not, there maybe a risk that fail to write DBGINST0/1.
Applied, thanks
>
> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> ---
>
> drivers/dma/pl330.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 88b884c..6a158ee 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -885,6 +885,12 @@ static inline void _execute_DBGINSN(struct pl330_thread *thrd,
> void __iomem *regs = thrd->dmac->base;
> u32 val;
>
> + /* If timed out due to halted state-machine */
> + if (_until_dmac_idle(thrd)) {
> + dev_err(thrd->dmac->ddma.dev, "DMAC halted!\n");
> + return;
> + }
> +
> val = (insn[0] << 16) | (insn[1] << 24);
> if (!as_manager) {
> val |= (1 << 0);
> @@ -895,12 +901,6 @@ static inline void _execute_DBGINSN(struct pl330_thread *thrd,
> val = le32_to_cpu(*((__le32 *)&insn[2]));
> writel(val, regs + DBGINST1);
>
> - /* If timed out due to halted state-machine */
> - if (_until_dmac_idle(thrd)) {
> - dev_err(thrd->dmac->ddma.dev, "DMAC halted!\n");
> - return;
> - }
> -
> /* Get going */
> writel(0, regs + DBGCMD);
> }
> --
> 2.7.4
>
>
--
~Vinod
prev parent reply other threads:[~2020-06-24 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 1:36 [PATCH v1] dmaengine: pl330: Make sure the debug is idle before doing DMAGO Sugar Zhang
2020-06-24 7:41 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624074141.GQ2324254@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sugar.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).