From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6533C433DF for ; Fri, 3 Jul 2020 07:42:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C05DC207DA for ; Fri, 3 Jul 2020 07:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593762125; bh=ytBBrNASNi4lreEswlKiG9zTyR8nMpCN2T+EsIZP4dM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RHIwiyrtD9syFHbrGxFGmqQzPaqv2uUXfB93h8n7hC9ktjJ6P1WYlOYXVkQtPYOr1 dK746sh3w+UrErjMRGwErPebciGxEHBLEBJp8vGp/oxaF/7iYo3E5t2G0/YGc2FMX5 I+oykW93TKIBIgSxA2z+tNzeGyGVbnMl6+Q8VrxM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726336AbgGCHmF (ORCPT ); Fri, 3 Jul 2020 03:42:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:60870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbgGCHmF (ORCPT ); Fri, 3 Jul 2020 03:42:05 -0400 Received: from localhost (unknown [122.182.251.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65FAC206B6; Fri, 3 Jul 2020 07:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593762124; bh=ytBBrNASNi4lreEswlKiG9zTyR8nMpCN2T+EsIZP4dM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jSvUHUNUrEn20qbxTBkbQKP8JuGvidWsl2Fl6NBxcgYKzCUJdDWKbEi2qRwY/eRdi Q1NWFV03GfuUnjoLSd5LJGzQAtutF3HcoM5FzbdNUo9P8RAXB08ZYtRIDtKJc2dfaZ xMB30M/w863jvJLhtwefYHdd2R8yKZ3aAIcGpGww= Date: Fri, 3 Jul 2020 13:12:00 +0530 From: Vinod Koul To: Sanjay R Mehta Cc: gregkh@linuxfoundation.org, dan.j.williams@intel.com, Thomas.Lendacky@amd.com, Shyam-sundar.S-k@amd.com, Nehal-bakulchandra.Shah@amd.com, robh@kernel.org, mchehab+samsung@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH v5 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA information Message-ID: <20200703074200.GL273932@vkoul-mobl> References: <1592356288-42064-1-git-send-email-Sanju.Mehta@amd.com> <1592356288-42064-4-git-send-email-Sanju.Mehta@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1592356288-42064-4-git-send-email-Sanju.Mehta@amd.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 16-06-20, 20:11, Sanjay R Mehta wrote: > From: Sanjay R Mehta > > Expose data about the configuration and operation of the > PTDMA through debugfs entries: device name, capabilities, > configuration, statistics. > > Signed-off-by: Sanjay R Mehta > --- > drivers/dma/ptdma/Makefile | 3 +- > drivers/dma/ptdma/ptdma-debugfs.c | 130 ++++++++++++++++++++++++++++++++++++++ > drivers/dma/ptdma/ptdma-dev.c | 8 +++ > drivers/dma/ptdma/ptdma.h | 9 +++ > 4 files changed, 149 insertions(+), 1 deletion(-) > create mode 100644 drivers/dma/ptdma/ptdma-debugfs.c > > diff --git a/drivers/dma/ptdma/Makefile b/drivers/dma/ptdma/Makefile > index 6fcb4ad..60e7c10 100644 > --- a/drivers/dma/ptdma/Makefile > +++ b/drivers/dma/ptdma/Makefile > @@ -6,6 +6,7 @@ > obj-$(CONFIG_AMD_PTDMA) += ptdma.o > > ptdma-objs := ptdma-dev.o \ > - ptdma-dmaengine.o > + ptdma-dmaengine.o \ > + ptdma-debugfs.o > > ptdma-$(CONFIG_PCI) += ptdma-pci.o > diff --git a/drivers/dma/ptdma/ptdma-debugfs.c b/drivers/dma/ptdma/ptdma-debugfs.c > new file mode 100644 > index 0000000..506c148b > --- /dev/null > +++ b/drivers/dma/ptdma/ptdma-debugfs.c > @@ -0,0 +1,130 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * AMD Passthrough DMA device driver > + * -- Based on the CCP driver > + * > + * Copyright (C) 2016,2020 Advanced Micro Devices, Inc. > + * > + * Author: Sanjay R Mehta > + * Author: Gary R Hook > + */ > + > +#include > +#include > + > +#include "ptdma.h" > + > +/* DebugFS helpers */ > +#define MAX_NAME_LEN 20 > +#define RI_VERSION_NUM 0x0000003F > + > +#define RI_NUM_VQM 0x00078000 > +#define RI_NVQM_SHIFT 15 > + > +static struct dentry *pt_debugfs_dir; > +static DEFINE_MUTEX(pt_debugfs_lock); > + > +static int pt_debugfs_info_show(struct seq_file *s, void *p) > +{ > + struct pt_device *pt = s->private; > + unsigned int regval; > + > + if (!pt) > + return 0; > + > + seq_printf(s, "Device name: %s\n", pt->name); > + seq_printf(s, " # Queues: %d\n", 1); > + seq_printf(s, " # Cmds: %d\n", pt->cmd_count); > + > + regval = ioread32(pt->io_regs + CMD_PT_VERSION); > + > + seq_printf(s, " Version: %d\n", regval & RI_VERSION_NUM); > + seq_puts(s, " Engines:"); > + seq_puts(s, "\n"); > + seq_printf(s, " Queues: %d\n", (regval & RI_NUM_VQM) >> RI_NVQM_SHIFT); > + > + return 0; > +} > + > +/* > + * Return a formatted buffer containing the current > + * statistics of queue for PTDMA > + */ > +static int pt_debugfs_stats_show(struct seq_file *s, void *p) > +{ > + struct pt_device *pt = s->private; > + > + seq_printf(s, "Total Interrupts Handled: %ld\n", pt->total_interrupts); > + > + return 0; > +} > + > +static int pt_debugfs_queue_show(struct seq_file *s, void *p) > + > +{ > + struct pt_cmd_queue *cmd_q = s->private; > + unsigned int regval; > + > + if (!cmd_q) > + return 0; > + > + seq_printf(s, " Pass-Thru: %ld\n", cmd_q->total_pt_ops); > + > + regval = ioread32(cmd_q->reg_int_enable); > + > + seq_puts(s, " Enabled Interrupts:"); > + if (regval & INT_EMPTY_QUEUE) > + seq_puts(s, " EMPTY"); > + if (regval & INT_QUEUE_STOPPED) > + seq_puts(s, " STOPPED"); > + if (regval & INT_ERROR) > + seq_puts(s, " ERROR"); > + if (regval & INT_COMPLETION) > + seq_puts(s, " COMPLETION"); > + seq_puts(s, "\n"); > + > + return 0; > +} > + > +DEFINE_SHOW_ATTRIBUTE(pt_debugfs_info); > +DEFINE_SHOW_ATTRIBUTE(pt_debugfs_queue); > +DEFINE_SHOW_ATTRIBUTE(pt_debugfs_stats); > + > +void ptdma_debugfs_setup(struct pt_device *pt) > +{ > + struct pt_cmd_queue *cmd_q; > + char name[MAX_NAME_LEN + 1]; > + struct dentry *debugfs_q_instance; > + > + if (!debugfs_initialized()) > + return; > + > + mutex_lock(&pt_debugfs_lock); > + if (!pt_debugfs_dir) > + pt_debugfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL); please do not create your own, you already have one under /sys/kernel/debug/dmaengine/<>/ use that :) > + mutex_unlock(&pt_debugfs_lock); > + > + pt->dma_dev.dbg_dev_root = debugfs_create_dir(pt->name, pt_debugfs_dir); argh, this is already created by core and you leaked that one and added your own! -- ~Vinod