From: Lee Jones <lee.jones@linaro.org>
To: dan.j.williams@intel.com, vkoul@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 15/17] dma: mv_xor_v2: Supply some missing 'struct mv_xor_v2_device' attribute docs
Date: Tue, 14 Jul 2020 12:15:44 +0100 [thread overview]
Message-ID: <20200714111546.1755231-16-lee.jones@linaro.org> (raw)
In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'clk' not described in 'mv_xor_v2_device'
drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'reg_clk' not described in 'mv_xor_v2_device'
drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'irq_tasklet' not described in 'mv_xor_v2_device'
drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'hw_queue_idx' not described in 'mv_xor_v2_device'
drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'msi_desc' not described in 'mv_xor_v2_device'
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/dma/mv_xor_v2.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
index 157c959311eaf..9225f08dfee92 100644
--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -135,9 +135,11 @@ struct mv_xor_v2_descriptor {
/**
* struct mv_xor_v2_device - implements a xor device
* @lock: lock for the engine
+ * @clk: reference to the 'core' clock
+ * @reg_clk: reference to the 'reg' clock
* @dma_base: memory mapped DMA register base
* @glob_base: memory mapped global register base
- * @irq_tasklet:
+ * @irq_tasklet: tasklet used for IRQ handling call-backs
* @free_sw_desc: linked list of free SW descriptors
* @dmadev: dma device
* @dmachan: dma channel
@@ -146,6 +148,8 @@ struct mv_xor_v2_descriptor {
* @sw_desq: SW descriptors queue
* @desc_size: HW descriptor size
* @npendings: number of pending descriptors (for which tx_submit has
+ * @hw_queue_idx: HW queue index
+ * @msi_desc: local interrupt descriptor information
* been called, but not yet issue_pending)
*/
struct mv_xor_v2_device {
--
2.25.1
next prev parent reply other threads:[~2020-07-14 11:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 11:15 [PATCH 00/17] Rid W=1 warnings in DMA Lee Jones
2020-07-14 11:15 ` [PATCH 01/17] dma: mediatek: mtk-hsdma: Fix formatting in 'struct mtk_hsdma_pdesc' doc block Lee Jones
2020-07-14 11:15 ` [PATCH 02/17] dma: of-dma: Fix misspellings/formatting issues in some function headers Lee Jones
2020-07-14 11:15 ` [PATCH 03/17] dma: ep93xx_dma: Provide some missing struct attribute documentation Lee Jones
2020-07-14 11:15 ` [PATCH 04/17] dma: mmp_pdma: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-14 11:15 ` [PATCH 05/17] dma: pl330: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-14 11:15 ` [PATCH 06/17] dma: ste_dma40: Supply 2 missing struct attribute descriptions Lee Jones
2020-07-14 11:15 ` [PATCH 07/17] dma: altera-msgdma: Fix struct documentation blocks Lee Jones
2020-07-16 7:04 ` Stefan Roese
2020-07-14 11:15 ` [PATCH 08/17] dma: at_hdmac: Repair parameter misspelling and demote non-kerneldoc headers Lee Jones
2020-07-14 11:15 ` [PATCH 09/17] dma: sun4i-dma: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-15 2:54 ` Chen-Yu Tsai
2020-07-14 11:15 ` [PATCH 10/17] dma: fsl-qdma: Fix 'struct fsl_qdma_format' formatting issue Lee Jones
2020-07-14 11:15 ` [PATCH 11/17] dma: imx-sdma: Correct formatting issue and provide 2 new descriptions Lee Jones
2020-07-14 11:15 ` [PATCH 12/17] dma: iop-adma: Function parameter documentation must adhere to correct formatting Lee Jones
2020-07-14 11:15 ` [PATCH 13/17] dma: nbpfaxi: Provide some missing attribute docs and split out slave info Lee Jones
2020-07-14 11:15 ` [PATCH 14/17] dma: xgene-dma: Provide descriptions for 'dev' and 'clk' in device's ddata Lee Jones
2020-07-14 11:15 ` Lee Jones [this message]
2020-07-14 11:15 ` [PATCH 16/17] dma: ioat: init: Correct misspelling of function parameter 'c' for channel Lee Jones
2020-07-14 11:15 ` [PATCH 17/17] dma: ioat: dma: Fix some parameter misspelling and provide description for phys_complete Lee Jones
2020-07-15 15:29 ` [PATCH 00/17] Rid W=1 warnings in DMA Vinod Koul
2020-07-15 15:37 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714111546.1755231-16-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).