Re: [PATCH v3 01/14] dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP'

Re: [PATCH v3 01/14] dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP'

[Vinod Koul]

On 29-06-20, 22:05, Sugar Zhang wrote:
> There is no reason to limit the performance on the 'NO-FLUSHP' SoCs,
> because 'FLUSHP' instruction is broken on these platforms, so remove
> the limit to improve the efficiency.

Applied, thanks

-- 
~Vinod

Re: [PATCH v3 02/14] dmaengine: pl330: Improve transfer efficiency for the dregs

[Vinod Koul]

On 29-06-20, 22:05, Sugar Zhang wrote:
> Only the unaligned burst transfers have the dregs.
> so, still use BURST transfer with a reduced size
> for better performance.

Applied, thanks

-- 
~Vinod

Re: [PATCH v3 03/14] dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst'

[Vinod Koul]

On 29-06-20, 22:05, Sugar Zhang wrote:
> This patch Adds the quirk 'arm,pl330-periph-burst' for pl330.

Applied, thanks

-- 
~Vinod

Re: [PATCH v3 04/14] dmaengine: pl330: Add quirk 'arm,pl330-periph-burst'

[Vinod Koul]

On 29-06-20, 22:05, Sugar Zhang wrote:
> This patch adds the qurik to use burst transfers only
> for pl330 controller, even for request with a length of 1.
> 
> Although, the correct way should be: if the peripheral request
> length is 1, the peripheral should use SINGLE request, and then
> notify the dmac using SINGLE mode by src/dst_maxburst with 1.
> 
> For example, on the Rockchip SoCs, all the peripherals can use
> SINGLE or BURST request by setting GRF registers. it is possible
> that if these peripheral drivers are used only for Rockchip SoCs.
> Unfortunately, it's not, such as dw uart, which is used so widely,
> and we can't set src/dst_maxburst according to the SoCs' specific
> to compatible with all the other SoCs.
> 
> So, for convenience, all the peripherals are set as BURST request
> by default on the Rockchip SoCs. even for request with a length of 1.
> the current pl330 driver will perform SINGLE transfer if the client's
> maxburst is 1, which still should be working according to chapter 2.6.6
> of datasheet which describe how DMAC performs SINGLE transfers for
> a BURST request. Unfortunately, it's broken on the Rockchip SoCs,
> which support only matching transfers, such as BURST transfer for
> BURST request, SINGLE transfer for SINGLE request.
> 
> Finally, we add the quirk to specify pl330 to use burst transfers only.

Applied, thanks

-- 
~Vinod

Re: [PATCH v3 0/14] Patches to improve transfer efficiency for Rockchip SoCs.

[Heiko Stuebner]

Am Montag, 29. Juni 2020, 16:05:41 CEST schrieb Sugar Zhang:
> Changes in v3:
> - rephrase commit message
> - fix typos in commit message
> - split the patch for [PATCH V2 1/14]
> - reorder the patch series
> 
> Changes in v2:
> - fix FATAL ERROR: Unable to parse input tree
> 
> Sugar Zhang (14):
>   dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP'
>   dmaengine: pl330: Improve transfer efficiency for the dregs
>   dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst'
>   dmaengine: pl330: Add quirk 'arm,pl330-periph-burst'
>   ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac
>   ARM: dts: rk322x: Add 'arm,pl330-periph-burst' for dmac
>   ARM: dts: rk3288: Add 'arm,pl330-periph-burst' for dmac
>   ARM: dts: rk3xxx: Add 'arm,pl330-periph-burst' for dmac
>   ARM: dts: rv1108: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: px30: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: rk3308: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: rk3328: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: rk3368: Add 'arm,pl330-periph-burst' for dmac
>   arm64: dts: rk3399: Add 'arm,pl330-periph-burst' for dmac

applied the patches 5-14 but merged them into one for arm32
and one for arm64 and did some slight reordering when the new
property was added at the bottom of the node.

Thanks
Heiko